diff options
author | Uwe Hermann <uwe@hermann-uwe.de> | 2008-11-27 00:47:07 +0000 |
---|---|---|
committer | Uwe Hermann <uwe@hermann-uwe.de> | 2008-11-27 00:47:07 +0000 |
commit | 1683cef9961efb3a8b843fce532da5ae640aac0b (patch) | |
tree | aeb4b351787869347efa69ff36cc7bffccd81f7b /src/northbridge/intel/i440bx/debug.c | |
parent | 544dca4195a6fb77286299bf42d4db5813dc28ac (diff) | |
download | coreboot-staging-1683cef9961efb3a8b843fce532da5ae640aac0b.zip coreboot-staging-1683cef9961efb3a8b843fce532da5ae640aac0b.tar.gz |
Remove the unnecessary memctrl[] indirection, 440BX only has one
memory controller.
Also, drop some unused '#if 0' code.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3773 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/northbridge/intel/i440bx/debug.c')
-rw-r--r-- | src/northbridge/intel/i440bx/debug.c | 34 |
1 files changed, 3 insertions, 31 deletions
diff --git a/src/northbridge/intel/i440bx/debug.c b/src/northbridge/intel/i440bx/debug.c index 77ebcc7..35ab611 100644 --- a/src/northbridge/intel/i440bx/debug.c +++ b/src/northbridge/intel/i440bx/debug.c @@ -1,11 +1,11 @@ -static void dump_spd_registers(const struct mem_controller *ctrl) +static void dump_spd_registers(void) { int i; print_debug("\r\n"); - for(i = 0; i < 4; i++) { + for(i = 0; i < DIMM_SOCKETS; i++) { unsigned device; - device = ctrl->channel0[i]; + device = DIMM_SPD_BASE + i; if (device) { int j; print_debug("dimm: "); @@ -31,34 +31,6 @@ static void dump_spd_registers(const struct mem_controller *ctrl) } print_debug("\r\n"); } -#if 0 /* Enable this if you have 2 memory channels */ - device = ctrl->channel1[i]; - if (device) { - int j; - print_debug("dimm: "); - print_debug_hex8(i); - print_debug(".1: "); - print_debug_hex8(device); - for(j = 0; j < 256; j++) { - int status; - unsigned char byte; - if ((j & 0xf) == 0) { - print_debug("\r\n"); - print_debug_hex8(j); - print_debug(": "); - } - status = spd_read_byte(device, j); - if (status < 0) { - print_debug("bad device\r\n"); - break; - } - byte = status & 0xff; - print_debug_hex8(byte); - print_debug_char(' '); - } - print_debug("\r\n"); - } -#endif } } |