summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Roth <martinroth@google.com>2015-12-08 15:26:03 -0700
committerMartin Roth <martinroth@google.com>2015-12-10 16:30:50 +0100
commit10f7f5044ec8364419a2722b2822db3d9d94a7ed (patch)
treea3f64b67d1c73326a0e6905de4c3b14148c2ea10
parentfad23134009291a7b992c1323ca815421a4b557d (diff)
downloadcoreboot-staging-10f7f5044ec8364419a2722b2822db3d9d94a7ed.zip
coreboot-staging-10f7f5044ec8364419a2722b2822db3d9d94a7ed.tar.gz
ACPI: Fix IASL Warning about unused method for GBUF check
According to the ACPI Spec for CondRefOf, the result argument is optional. In all of these locations, it was getting set but not used, creating a warning in new versions of IASL. Since it's an optional argument, just remove it. dsdt.aml 640: If (CondRefOf (^GBUF, Local0)) { Warning 3144 - Method Local is set but never used ^ (Local0) Change-Id: Ie2f46808e92c309a63ba7661bcbd77402a08366a Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/12694 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
-rw-r--r--src/soc/intel/baytrail/acpi/lpe.asl2
-rw-r--r--src/soc/intel/braswell/acpi/lpe.asl2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/intel/baytrail/acpi/lpe.asl b/src/soc/intel/baytrail/acpi/lpe.asl
index a8ebc35..1f13fe5 100644
--- a/src/soc/intel/baytrail/acpi/lpe.asl
+++ b/src/soc/intel/baytrail/acpi/lpe.asl
@@ -68,7 +68,7 @@ Device (LPEA)
Store (\LPFW, BAS2)
/* Append any Mainboard defined GPIOs */
- If (CondRefOf (^GBUF, Local0)) {
+ If (CondRefOf (^GBUF)) {
ConcatenateResTemplate (^RBUF, ^GBUF, Local1)
Return (Local1)
}
diff --git a/src/soc/intel/braswell/acpi/lpe.asl b/src/soc/intel/braswell/acpi/lpe.asl
index b213fe6..6dd73ab 100644
--- a/src/soc/intel/braswell/acpi/lpe.asl
+++ b/src/soc/intel/braswell/acpi/lpe.asl
@@ -68,7 +68,7 @@ Device (LPEA)
Store (\LPFW, BAS2)
/* Append any Mainboard defined GPIOs */
- If (CondRefOf (^GBUF, Local0)) {
+ If (CondRefOf (^GBUF)) {
ConcatenateResTemplate (^RBUF, ^GBUF, Local1)
Return (Local1)
}
OpenPOWER on IntegriCloud