path: root/flash.h
diff options
authorCarl-Daniel Hailfinger <>2008-11-28 23:45:27 +0000
committerCarl-Daniel Hailfinger <>2008-11-28 23:45:27 +0000
commit6a0a25cada03fc6a36a065db18b29ca832288aa6 (patch)
tree43c7d76d6be2b101cc4d8c7c6040dfc977cb6701 /flash.h
parenta3f04be761d45aed2f6113eb2a6d08679370f546 (diff)
Do not indicate known-bad functions as untested
If a chip has any TEST_BAD_* flag set, we don't even list the unsupported functions, giving the user the impression that the unsupported functions are tested. Corresponding to flashrom svn r352 and coreboot v2 svn r3780. Signed-off-by: Carl-Daniel Hailfinger <> Acked-by: Peter Stuge <>
Diffstat (limited to 'flash.h')
1 files changed, 2 insertions, 1 deletions
diff --git a/flash.h b/flash.h
index cbc2e48..70a390f 100644
--- a/flash.h
+++ b/flash.h
@@ -95,6 +95,7 @@ struct flashchip {
#define TEST_BAD_READ (1<<5)
#define TEST_BAD_ERASE (1<<6)
#define TEST_BAD_WRITE (1<<7)
#define TEST_BAD_MASK 0xf0
extern struct flashchip flashchips[];
@@ -106,7 +107,7 @@ extern struct flashchip flashchips[];
* All LPC/FWH parts (parallel flash) have 8-bit device IDs if there is no
* continuation code.
- * All SPI parts have 16-bit device IDs.
+ * SPI parts have 16-bit device IDs if they support RDID.
#define GENERIC_DEVICE_ID 0xffff /* Only match the vendor ID */
OpenPOWER on IntegriCloud