- Throw ezcBaseValueExceptions instead of typecasting

- Do range checks instead of converting numbers using min and max
- Extended testcases to test for ezcBaseValueExceptions

1 files changed, 61 insertions, 1 deletions

diff --git a/tests/dataset_average_test.php b/tests/dataset_average_test.php
index a2c9ae0..6ab21c6 100644
--- a/tests/dataset_average_test.php
+++ b/tests/dataset_average_test.php
@@ -294,7 +294,7 @@ class ezcGraphDataSetAverageTest extends ezcTestCase
         $this->fail( 'Expected ezcGraphDatasetAverageInvalidKeysException.' );
     }
 
-    public function testPAverageDataSetIsset()
+    public function testAverageDataSetIsset()
     {
         $arrayDataSet = new ezcGraphArrayDataSet( array( -1 => 2, 1 => 2, 3 => 10 ) );
 
@@ -308,5 +308,65 @@ class ezcGraphDataSetAverageTest extends ezcTestCase
             'Polygon not properly initialized.'
         );
     }
+
+    public function testDataSetAveragePolynomPropertyPolynomOrder()
+    {
+        $arrayDataSet = new ezcGraphArrayDataSet( array( -1 => 2, 1 => 2, 3 => 10 ) );
+        $dataset = new ezcGraphDataSetAveragePolynom( $arrayDataSet );
+
+        $this->assertSame(
+            3,
+            $dataset->polynomOrder,
+            'Wrong default value for property polynomOrder in class ezcGraphDataSetAveragePolynom'
+        );
+
+        $dataset->polynomOrder = 5;
+        $this->assertSame(
+            5,
+            $dataset->polynomOrder,
+            'Setting property value did not work for property polynomOrder in class ezcGraphDataSetAveragePolynom'
+        );
+
+        try
+        {
+            $dataset->polynomOrder = false;
+        }
+        catch( ezcBaseValueException $e )
+        {
+            return true;
+        }
+
+        $this->fail( 'Expected ezcBaseValueException.' );
+    }
+
+    public function testDataSetAveragePolynomPropertyResolution()
+    {
+        $arrayDataSet = new ezcGraphArrayDataSet( array( -1 => 2, 1 => 2, 3 => 10 ) );
+        $dataset = new ezcGraphDataSetAveragePolynom( $arrayDataSet );
+
+        $this->assertSame(
+            100,
+            $dataset->resolution,
+            'Wrong default value for property resolution in class ezcGraphDataSetAveragePolynom'
+        );
+
+        $dataset->resolution = 5;
+        $this->assertSame(
+            5,
+            $dataset->resolution,
+            'Setting property value did not work for property resolution in class ezcGraphDataSetAveragePolynom'
+        );
+
+        try
+        {
+            $dataset->resolution = false;
+        }
+        catch( ezcBaseValueException $e )
+        {
+            return true;
+        }
+
+        $this->fail( 'Expected ezcBaseValueException.' );
+    }
 }
 ?>