| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\ |
|
| |
| |
| |
| | |
As suggested by Renato.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
1) A disabled gateway can always be enabled - no extra validation
needed.
2) When disabling an enabled gateway, check to see that the gateway is
not used in any gateway group or enabled static route (similar tests to
what is already checked before deleting a gateway).
3) A static route can always be disabled - no extra checks needed.
4) When enabling a static route, check that the selected gateway is
enabled - you cannot have a static route enabled on a disabled gateway.
5) Do the address family cross-check between static route and gateway
even when the static route is disabled - we do not want to save
mismatched IP address families in any case.
This covers all the cases I can see to ensure that the enable/disable
status combinations of Gateways and Static Routes is always valid.
|
|/
|
|
|
|
|
|
|
|
|
| |
If there is an input error then the edit page is redrawn showing the
input errors. The HTTP_REFERER becomes the current page, rather than the
true original referer. Then if you click Cancel the current page is just
redrawn.
This change makes the code remember the original referer, so if the user
enters some invalid data, presses Save, reads the input error messages
then presses Cancel they are taken back out to the original page - the
same as if Cancel was used before Save.
|
|
|
|
|
|
|
| |
and other random stuff I noticed.
I think this finishes messing with code style. The codebase should match
the developer style guide closely enough that 99.9% of changes will not
feel the need to also massage the formatting.
|
| |
|
|
|
|
|
| |
and module names and other bits of formatting and typos in header
comment sections.
|
| |
|
| |
|
|
|
|
| |
HTTP_REFERER, there are a couple of places I didn't touch on this commit because it requires more work
|
|
|
|
|
|
| |
match is case-sensitive and hasn't matched the openbgpd package's name in
at least 5 years, so it doesn't do anything. It's far from functional in
any useful manner even fixing that issue.
|
|\
| |
| |
| | |
ayvis-master-br
|
| |
| |
| | |
replaced <br>, <br/> and </br> with <br />
|
|/ |
|
|
|
|
| |
they are numeric integer, also, pass them through htmlspecialchars() before print
|
|
|
|
|
| |
Recommended changes made to calculated value input behavior.
Restrict interval to integer of 1 or greater.
|
|
|
|
|
|
|
|
|
| |
Exposes 3 additional apinger configuration options in the gateway monitor advanced section which can either be set manually, calculated based on interval, or use the hard coded defaults.
1) Avg Delay Samples
2) Avg Loss Samples
3) Avg Loss Delay Samples
The current hard coded defaults are okay for a short interval such as the 1 second default. But do not work well when a longer interval is required.
|
| |
|
|
|
|
| |
when it's disabled
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
By default htmlspecialchars does not consider single quotes, what can be
a problem when value attribute is set using it. Replace value attribute
set to use double quotes on places where it's obviously recieving a
result of htmlspecialchars() call.
|
| |
|
|
|
|
| |
more than one default gateway when it's dynamic
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Add CDATA section to SCRIPT tags
Close INPUT and BR tags
Update HTML boolean operators
|
| |
|
|
|
|
| |
http://forum.pfsense.org/index.php/topic,58399.0.html and http://forum.pfsense.org/index.php/topic,58273.0.html
|
|
|
| |
Correct IP family mix-up.
|
|
|
|
| |
Standardise all PHP start tags from "<?" to "<?PHP"
|
| |
|
| |
|
|
|
|
|
| |
Use the default values from return_apinger_defaults.
Validate values - low less than high, probe interval less than "down" time, values are positive numeric.
Update descriptions on the UI to show the defaults used.
|
|
|
|
|
|
| |
this check a lot simpler and do less guessing.
Redmine ticket #2503
|
|
|
|
|
|
|
|
|
|
|
| |
won't work.
People will likely need to edit and save their gateways now if they have double entries.
e.g. both manual and automatically added entries, these will dissapear as soon as you save.
If we know if the gateway or monitor is ipv4 or ipv6 we can autodetect which prevents this.
Because we don't know what address family the gateway on a dual stack interface belongs to we better not guess, and let the user figure it out. Often, a edit and save is the fastest.
For upgrading from 2.0 we could mark all gateways as being ipv4 which prevents half of the issues.
Redmine ticket #2463
|
|
|
|
|
|
|
| |
edit screen.
With added validation and multiple detection parts to work when the value is not set yet.
Redmine ticket #2463
|
| |
|
|
|
|
| |
Input validaton on interface gateway creation box needs to reject duplicate names
|
| |
|
|
|
|
| |
Ticket #2071
|
|
|
|
| |
Backend already added the interface scope for link local addresses, hurrah.
|
|
|
|
| |
parameters.
|