| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| | |
|
|/ |
|
| |
|
| |
|
|
|
| |
The index needs to be incremented even for entries that were skipped for display because they (for whatever reason) have no MAC or CID set. So use the key directly from the array.
|
| |
|
|
|
|
|
|
| |
1) If there is a Client Id specified then show it (otherwise it is possible to define a Static Mapping that has only Client Id and all other fields empty, which would look like an empty row in the displayed table).
2) Ignore empty static lease entries - when an interface has no static mappings the "static" section of the DHCP server settings can be "" which was resulting in a single-element that was empty being displayed as an empty row.
3) If there are no leases to display, then make a row with the message "No leases to display" so the user knows the system at least tried.
4) If there are no leases in use, then make a row with the message "No leases are in use" so the user knows the system at least tried.
|
|
|
| |
Each row of the table needs a tr end, only the last row was getting the tr end.
|
| |
|
|
|
|
|
|
|
|
|
| |
It seems odd to me that when the times are displayed in UTC they have
24-hour clock, but when displayed in local time they are formatted with
12-our clock and AM/PM.
24-hour format takes less screen space, and I would have thought that
network admins would prefer working consistently in 24-hour clock
format.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required.
It seems to me that there is no harm at all in always using
require_once().
|
|
|
| |
Redmine #6079
|
|
|
|
|
|
| |
etc). Ticket #5965
Still need to review Advanced buttons and Repeatable block buttons.
|
| |
|
|
|
|
|
|
|
| |
1) Add code from RELENG_2_2 https://github.com/pfsense/pfsense/commit/cf3aff59edfa4b101d69ddd694a59fdc580d2299 that checks for leases that are in pools other than the ordinary first pool. This code has been missed from the bootstrap conversion.
2) Make the leases per interface/pool work properly. The counter $dlsc did not get incremented much anyway, because of break statements in the previous code. I have made it key $dhcp_leases_subnet_counter by the interface and starting IP of the pool - this is a unique identifier of each pool, so the counter for it can be reliably incremented as leases are considered in any order.
3) Sort $dhcp_leases_subnet_counter before displaying the counter data - that way the displayed data is always nicely ordered by interface name and then increasing pool start IP, regardless of the order that the leases happened to be found.
|
| |
|
|
|
|
| |
more consistent. Convert page title to title case.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Sort routine apparently does not honor colspan attribute.
Here are three possible solutions:
1) Add a description column instead of spanning the start and end columns. This is the method presented in this commit.
2) Include an empty second column with the description instead of spanning. This would not be very display/sort friendly though because it would be sharing the start column with the description.
3) Display two empty cells when lease type is static, instead of the description. This is the way status DHCPv6 leases currently works.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
1) Put the heading "Actions" at the top of all the "Actions" columns -
it was on some and not others.
2) Some more consistent capitalization of panel titles etc.
3) Most interfaces section edit pages had a section titled like "GIF
Configuration", "GRE Configuration". Make them all consistent, e.g.
"QinQ Configuration" rather than "Interface QinQ Edit"...
|
| |
|
|
|
|
| |
ip2long32() etc
|
| |
|
| |
|
|
|
|
|
|
| |
Short open tag is discouraged since it is only available if enabled
See https://secure.php.net/manual/en/language.basic-syntax.phptags.php
|
|
|
|
| |
was the reason they were added, it was never finished and it's not being used
|
| |
|
|
|
|
| |
are all pages and the "WebCfg" prefix implies they are pages.
|
| |
|
|
|
|
| |
Mote: New ticket will be opened to provide IP address sorting
|
|
|
|
|
|
| |
- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
i broke the counter when i added the interface column.
should be ok now.
|
| |
|
|
|
|
|
|
| |
Added table style classes
Changed array keys to descriptive names
Updated indenting/style
|
|
|
| |
https://redmine.pfsense.org/issues/5186
|
| |
|
|
|