| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
1) Strictly keep track of the accumulating $retval from calls to various
functions that apply changes.
2) Use new function print_apply_result_box() to print a suitable message
in a suitable severity based on $retval
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required.
It seems to me that there is no harm at all in always using
require_once().
|
| |
|
|
| |
Remove "you" personalizations.
|
| |
|
|
| |
The call itself to print_info_box already echoes the content. There is no need of additionally using the short-open-echo tag on those calls to echo return value. The previous implementation shouldn't yell any visible issues as return is 'NULL' (undefined) which casts to an empty string when printing. But, just for the sake of conformity, this changes are advisable in my opinion.
|
| |
|
|
| |
/usr/local/www/services_igmpproxy.php on line 109
|
| |
|
|
|
|
|
|
|
|
| |
1) For the translators, it should be better to do it consistently. Then
they only need to have 1 translation of "You must apply the changes in
order for them to take effect" and can translate each of the other
custom sentences individually.
2) The full-stop should always go at the end of the sentence, inside the
gettext(). There are some languages where the full-stop is not the same
as European. e.g. In Nepal we use the vertical bar for end of sentence.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show.
3) Delete function print_info_box_np_undo() - nothing calls it.
4) Add new function print_apply_box() to provide an easy wrapper for
print_info_box() with the parameters to be 'warning' level and 'apply'
button.
5) Change print_info_box_np() calls to just print_info_box() or
print_apply_box() as appropriate.
There is 1 direct call to print_info_box_np() from vpn_ipsec_mobile.php
remaining. That tries to make a "create" button. It was not working
before this change. It needs to be sorted out and fixed separately.
After this change there is no dependency on a string containing text
like "apply" to make the apply button appear.
Then we can work on re-engineering the internal code of
print_info_box_np() print_info_box() and print_apply_box() to fit
together however we like. It should be easy to preserving the current
API to print_info_box() and print_apply_box().
|
| |
|
|
|
|
|
|
|
| |
1) Put the heading "Actions" at the top of all the "Actions" columns -
it was on some and not others.
2) Some more consistent capitalization of panel titles etc.
3) Most interfaces section edit pages had a section titled like "GIF
Configuration", "GRE Configuration". Make them all consistent, e.g.
"QinQ Configuration" rather than "Interface QinQ Edit"...
|
| | |
|
| | |
|
| |
|
|
|
|
| |
instrad of <div id="infoblock"
Just makes more sense to use a class for this
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"firewall_aliases.php"
- add gettext to the H2 tag
- remove debug code
"sevices_igmpproxy.php"
"services_pppoe.php"
"vpn_ipsec_keys.php"
"status_gateways.php"
"status_gateway_groups.php"
"statis_services.php"
"diag_arp.php"
"diag_ndp.php"
- add Bootstrap panels
|
| |
|
|
| |
- Close TH tag correctly
|
| | |
|
| |
|
|
| |
was the reason they were added, it was never finished and it's not being used
|
| |
|
|
| |
are all pages and the "WebCfg" prefix implies they are pages.
|
| | |
|
| |
|
|
|
|
| |
- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
'X' button suppressed in info text box
|
| | |
|
| | |
|
| | |
|
| |
|
