| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Increase max number of characters allowed in a tab array to 256 to prevent automatic conversion to pull-down
|
| |
|
|\ |
|
| |
| |
| | |
I was tearing my hair out for a while. If do_input_validation() is passed some array of keys/values that has been assembled elsewhere (not $_POST, $_GET or $_REQUEST superglobals) then it does not work. The code here, for at least the last 7 years, has actually been checking the array keys in the "hard-coded" superglobals. That is a bit surprising, since the array to be checked is passed in as $postdata parameter.
|
|/ |
|
|\ |
|
| |
| |
| |
| | |
preventing other requests from being blocked longer than required.
|
| |
| |
| |
| | |
xml's, fix tabgroup filter
|
| | |
|
| |
| |
| |
| | |
Signed-off-by: Phil Davis <phil.davis@inf.org>
|
|/
|
|
| |
Signed-off-by: Phil Davis <phil.davis@inf.org>
|
| |
|
|
|
|
| |
guiconfig.php display_top_tabs supports "usepost" as an optional 4th argument
|
| |
|
| |
|
| |
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
It should fix #7111
Submitted by @ubawurinna at https://github.com/pfsense/pfsense/pull/2687
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| | |
1) Strictly keep track of the accumulating $retval from calls to various
functions that apply changes.
2) Use new function print_apply_result_box() to print a suitable message
in a suitable severity based on $retval
|
|/
|
| |
It came into use in https://github.com/pfsense/pfsense/commit/45eebe10a93fa1e2399c6cdf133ad88dc21ee6e7 but genhtmltitle() has changed since then and no longer uses $heading
|
|
|
|
| |
the GUI. In particular, note when there are no capable interfaces assigned. Implements #7032
|
| |
|
|
|
|
| |
properly respect the timeouts. Ticket #6803
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
For safety, use include_once() when including various "side" files.
There are a couple of instances of include("guiconfig,inc") that I
changes to use require_once() to be consistent with everywhere else.
The remaining cases of include() are just (hundreds of) head.inc and
footer.inc - those are only at the start/end of the ordinary top-level
interactive PHP files. There is no nested interaction of those to think
about, so that should be fine.
|
|
|
| |
Stops PHP warnings like reported in forum https://forum.pfsense.org/index.php?topic=111768.0
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The last test here looks not good having just a single equals sign - if the interpreter evaluates this then $class will always get set to 'info'.
In practice it should work OK, because the evaluation of boolean conditions left to right should stop when any of the other tests to the left evaluates false. So $class will only be set to 'info' if it is not already 'default' 'danger' or 'warning'.
Actually the code could be:
a) Obfuscated version with empty if block content:
if ($class != 'default' && $class != 'danger' && $class != 'warning' && $class = 'info') {
// Noop - the if test above has already set $class to 'info' as required.
}
or
b) Clearer version without bothering with any test for $class != 'info' :
if ($class != 'default' && $class != 'danger' && $class != 'warning') {
$class = 'info';
}
|
|\
| |
| |
| |
| | |
* 'patch-9' of https://github.com/k-paulius/pfsense:
Stop generating page-header instead of hiding it. With breadcrumbs introduces it no longer serves any useful purpose.
|
| |
| |
| |
| | |
introduces it no longer serves any useful purpose.
|
|/ |
|
| |
|
| |
|
| |
|
|
|
|
| |
will know what happeded
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put the real code into print_info_box, adding just a $btntext parameter
to the existing 3 params of print_info_box.
Change the remaining print_info_box_np() calls to use print_info_box()
Note: The previous code also had a "bug" - the "apply" button said
"apply" literally on the UI, when it should have said "Apply changes".
That is fixed so that now the "Apply changes" or other specified button
text is actually displayed to the user. (In the old code it was
literally displaying $name when it should have been $value)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show.
3) Delete function print_info_box_np_undo() - nothing calls it.
4) Add new function print_apply_box() to provide an easy wrapper for
print_info_box() with the parameters to be 'warning' level and 'apply'
button.
5) Change print_info_box_np() calls to just print_info_box() or
print_apply_box() as appropriate.
There is 1 direct call to print_info_box_np() from vpn_ipsec_mobile.php
remaining. That tries to make a "create" button. It was not working
before this change. It needs to be sorted out and fixed separately.
After this change there is no dependency on a string containing text
like "apply" to make the apply button appear.
Then we can work on re-engineering the internal code of
print_info_box_np() print_info_box() and print_apply_box() to fit
together however we like. It should be easy to preserving the current
API to print_info_box() and print_apply_box().
|
| |
|
|
|
|
| |
console
|
|
|
| |
This is the quick fix part (1) for https://redmine.pfsense.org/issues/5794
|
| |
|