| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
|
| |
sectiom
e.g.: $section = new Form_Section("My section", "a_here");
then: https://firewall/system_somepage.php#a_here
|
|
|
|
| |
This should eliminate all the issues caused by packages with embedded '%' in their text
|
|\ |
|
| | |
|
|/ |
|
|
|
|
| |
lists. e.g.: setHelp("%d interfaces have been detected", $numIfs);
|
|
|
|
| |
Provides setRequired() Javascript function to facilitate making an input required or not dynamically
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When composing an element with a form.class or via XML, prepend a '*' to the title to indicate a required field. This will cause the "element-required" class to be added to the label. pfSense.css contains the style associated with that class. (Currently a custom underline).
e.g.:
$section->addInput(new Form_Input(
'name',
'*Name',
'text',
$pconfig['name']
))->setPattern('[a-zA-Z0-9_]+')->setHelp('The name of the alias may only consist '.
'of the characters "a-z, A-Z, 0-9 and _".');
|
|
|
|
|
|
|
|
|
|
| |
1) Add alias and host types to Form_IpAddress with the appropriate hover
text.
2) Remove the patterns - the UI of those is not so effective anyway, so
leave the validation of input to the back end.
3) Update uses of Form_IpAddress to use the appropriate Alias or Host
type as needed.
4) Remove explicit setPattern() from those uses of Form_IpAddress.
|
|
|
|
|
| |
When requiring the entry of an IPv6 address, the regex pattern should still allow a dot, so that an IPv6 address can be entered in the format that has an IPv4-address-like part at the end:
aa:bb:cc:dd:ee:ff:1.2.3.4
which is a valid way to choose to specify an IPv6 address.
|
|
|
|
| |
This reverts commit d461ff40e364fc0ecc003b9f673cbad7c6a08f2f.
|
|
|
|
| |
This reverts commit 9444a281f051e11d5456cc37b2a3f56fc8a7bc33.
|
|
|
|
|
|
|
|
|
|
| |
Expand the types of Form_IpAddress so that the caller can specify
exactly what combination of IPv4, IPv6 address and alias is allowed for
the field.
Set the appropriate input pattern and hover help text.
Only toLowercase() the entered value if it has a ":" in it - i.e. it
looks like it is intended to be an IPv6 address (rather than an IPv4 or
an alias name).
|
|
|
|
|
| |
As it is no longer relevant, because the code now automatically converts
to lowercase.
|
|
|
|
|
|
|
|
| |
1) As the user leaves the field, or presses Save, onChange will fire and
convert the input string to lowercase. This saves the user havng to even
think about it.
2) Provide some extra text that describes the expected format, to avoid
them getting just "Please match the requested format"
|
| |
|
|
|
|
| |
No functional change - just making style consistent
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
1) If a checkbox does not have a description (even if it is empty), layout will be broken as checkbox won't be aligned correctly
2) UPnP checkbox looks better with description instead of help
This commit fixes the two issues
|
| | |
|
| | |
|
| | |
|
|/ |
|
|\ |
|
| | |
|
|/
|
| |
It seems to me that a through f should not be part of the pattern for the "V4" case.
|
|\ |
|
| |
| |
| |
| | |
Apparently gettext() does not behave correctly when passed an empty string, this commit ensures gettext() is called only with non-empty strings
|
|/
|
|
|
|
| |
this case it is specified as "V6".
(cherry picked from commit 3e4adb7139b4cddbb06a2aba7e0727d1762b35ee)
|
|
|
|
|
|
| |
This limit is set at 4096 on PHP 5.6: http://lxr.php.net/xref/PHP_5_6/ext/gettext/gettext.c#139
Bug report on forum: https://forum.pfsense.org/index.php?topic=110088.0
|
| |
|
| |
|
|
|
|
|
| |
Note: This will cause a problem for some code that does comparisons expecting this text to be exactly the string 'Save'. If the user has selected a different language then the button text will be translated and thus will be some different text.
That is discussed in forum https://forum.pfsense.org/index.php?topic=108116.0
I will followup with another pull request to fix the things I can find like that.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't call gettext with an empty title.
There are undoubtedly other places that a check should be done before passing a variable only to a gettext call.
Fixes use case of form group class without a title from passing empty var to gettext.
Gettext returns header info. when an empty string/var is passed.
Perhaps a function should be created for this for consistency.
http://php.net/manual/en/function.gettext.php#108594
For groups without a title gettext returns header info.
To reproduce the issue select a non English language and open any of the following:
Services Load Balancer - edit
Diagnostics - Backup/Restore
Diagnostics - Status SMART
Status - System Logs - log filter and manage log panels
(not a comprehensive list)
|
|
|
|
| |
and Chromium
|
|
|
|
| |
inconsistent handling of checkboxes in packages.
|
|
|
|
|
| |
renamed get_type to getType
fix capitalisation in getTagName
|
|
|
|
| |
packages.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The name attribute is obsolete. Consider putting an id attribute on the nearest container instead.
The <a> name attribute is not supported in HTML5. Use the id attribute instead.
|
|
|
|
| |
but it might as well work just in case.
|
| |
|
| |
|