summaryrefslogtreecommitdiffstats
path: root/src/usr/local/www/classes
Commit message (Collapse)AuthorAgeFilesLines
* Adding {} to if statement.NOYB2016-01-221-1/+2
|
* Form Group - Empty Title GetTextNOYB2016-01-221-1/+2
| | | | | | | | | | | | | | | | | | | | | Don't call gettext with an empty title. There are undoubtedly other places that a check should be done before passing a variable only to a gettext call. Fixes use case of form group class without a title from passing empty var to gettext. Gettext returns header info. when an empty string/var is passed. Perhaps a function should be created for this for consistency. http://php.net/manual/en/function.gettext.php#108594 For groups without a title gettext returns header info. To reproduce the issue select a non English language and open any of the following: Services Load Balancer - edit Diagnostics - Backup/Restore Diagnostics - Status SMART Status - System Logs - log filter and manage log panels (not a comprehensive list)
* classes/Form/Textarea.class.php, setNoWrap, make it work properly on FireFox ↵PiBa-NL2016-01-181-1/+1
| | | | and Chromium
* Put this htmlspecialchars back, I found a better workaround for the ↵jim-p2016-01-171-1/+1
| | | | inconsistent handling of checkboxes in packages.
* Fix inconsistencies in Form_InputSjon Hortensius2016-01-172-4/+4
| | | | | renamed get_type to getType fix capitalisation in getTagName
* Don't run the checkbox label through htmlspecialchars, it breaks several ↵jim-p2016-01-161-1/+1
| | | | packages.
* Don't automatically run strings that are too long through gettext here.jim-p2016-01-161-1/+6
|
* Change method name to setIsRequired() to match other similar methodsStephen Beaver2016-01-061-1/+1
|
* Added new method setRequired() (shortcut for setAttribute("required", true) )Stephen Beaver2016-01-061-0/+7
|
* HTML Compliance - Form Button - HRefNOYB2016-01-051-0/+3
| | | | | The name attribute is obsolete. Consider putting an id attribute on the nearest container instead. The <a> name attribute is not supported in HTML5. Use the id attribute instead.
* Correct "noWrap" in text areas. (Function is not actually used by anyone, ↵Stephen Beaver2016-01-041-1/+1
| | | | but it might as well work just in case.
* Final updates in support of hidden passwordsStephen Beaver2015-12-291-1/+1
|
* Don't display dummy password if configured pwd is emptyStephen Beaver2015-12-282-1/+9
|
* Experimental: Fixed #5693Stephen Beaver2015-12-282-0/+34
| | | | Added new functionality to PHP classes, and used it ONLY in system_advanced_notifications.php -> smtp password
* Move width:auto style to textarea handler in pkg_edit.phpStephen Beaver2015-12-221-3/+1
|
* Merge pull request #2316 from phil-davis/patch-3Stephen Beaver2015-12-221-2/+9
|\
| * HTML Compliance - Form Select 3rd tryPhil Davis2015-12-221-2/+9
| | | | | | | | | | This is a combined version of: https://github.com/pfsense/pfsense/pull/2310 https://github.com/pfsense/pfsense/pull/2315
* | Merge pull request #2295 from NOYB/HTML_Compliance_-_Form_Input_-_PlaceholderStephen Beaver2015-12-221-1/+3
|\ \ | |/ |/|
| * HTML Compliance - Form Input - PlaceholderNOYB2015-12-181-1/+3
| | | | | | | | | | Attribute placeholder not allowed on element select at this point. Attribute placeholder is only allowed when the input type is email, number, password, search, tel, text, or url.
* | Default textarea width to 60 cols.Stephen Beaver2015-12-221-0/+1
| | | | | | | | Use setCols() to override
* | Adds style="width: auto;" attribute to textareas to allow the "cols" ↵Stephen Beaver2015-12-221-0/+1
| | | | | | | | attribute to take effect. Required bu pkg_edit.php and by wizards
* | Reverts change to Form_Selector which was breaking selectors with blank optionsStephen Beaver2015-12-221-2/+1
| |
* | Added support for rows, cols and wrap to Forms_Textarea and to pkg_edit.phpStephen Beaver2015-12-212-0/+21
| |
* | Merge pull request #2298 from NOYB/WebGUI_Left_Column_Labels_HyperStephen Beaver2015-12-211-0/+5
|\ \
| * | WebGUI Left Column Labels HyperNOYB2015-12-191-0/+5
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Touch Screen Usability Annoyance https://forum.pfsense.org/index.php?topic=104135.0 Clicking the labels in the left column selects/activates the first item. This is the perfectly natural place for scrolling with thumb. No big problem really for input fields, but check boxes and buttons are inadvertently selected/toggled resulting in unintended configuration changes. Would be real nice if the labels in the left column were not "active". This commit provides an option in System - General Setup page to enable/disable this "feature". There is probably a better way, but this appears to be functional. For now at least it seems to work for me anyway. Just have to eliminate (null) the for attribute on the group labels so it doesn't have a target.
* | HTML Compliance - Form Group - Label ForNOYB2015-12-212-1/+17
| | | | | | | | The for attribute of the label element must refer to a non-hidden form control.
* | HTML Compliance - Form SelectNOYB2015-12-181-1/+2
|/ | | | Element option without attribute label must not be empty.
* Applying htmlspecialchars on form action attribute causes ampersands to ↵NOYB2015-12-151-1/+1
| | | | multiply, and also breaks multi-parameter query strings that are delimited with ampersands.
* Automatic panel collapse defines moved to jquery/pfSenseHelpsers.jsStephen Beaver2015-12-141-3/+0
| | | | | | define(COLLAPSIBLE, 0x08); define(SEC_CLOSED, 0x04); define(SEC_OPEN, 0x00);
* Merge pull request #2217 from ↵Stephen Beaver2015-12-141-2/+2
|\ | | | | | | NOYB/HTML_Compliance_-_Collapsible_Form_Section_HREF
| * HTML Compliance - Collapsible Form Section HREFNOYB2015-12-131-2/+2
| | | | | | | | | | | | | | | | | | Bad value for attribute href on element a: Illegal character in fragment: not a URL code point. <a data-toggle="collapse" href="#<id> .panel-body"> Syntax of URL:Any URL. For example: /hello, #canvas, or http://example.org/. Characters should be represented in NFC and spaces should be escaped as %20. Fix is to set an id on the target.
* | Merge pull request #2216 from ↵Stephen Beaver2015-12-141-1/+7
|\ \ | | | | | | | | | NOYB/HTML_Compliance_-_Checkbox_Display_As_Radio_Unique_ID
| * | HTML Compliance - Checkbox Display As Radio Unique IDNOYB2015-12-131-1/+7
| |/ | | | | | | | | | | | | | | Ensure checkbox display as raido has unique id. Allow an id to be passed in displayAsRadio() as argument[0]. If no argument is passed, construct id as name_value:uniqid. Previous behavior was id = name. So all the radio buttons of the set had same id.
* | HTML Compliance - Form Action AttributeNOYB2015-12-121-2/+3
|/ | | | | | | | | | | | | | | | | Fix Empty Form Action Attribute Violation An empty form action attribute is an HTML4 and HTML5 specification violation. http://www.w3.org/TR/html5/forms.html#attr-fs-action "The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." The HTML4 specification requires that the form action attribute be present and contain a valid URI. Empty is not a valid URI. Though an empty form action attribute may currently function there is no guarantee it will continue to do so in the future or to do so as xpected. Since it does not adhere to the specification it is left open for each browser to handle in any way they choose. And to change that behavior at any time for any reason. Populating the form action attribute with the current URI covers both HTML4 and HTML5 specifications. Don't leave it open to browser interpretation. Give explicit instructions to the browser by adhering to the specification.
* Revise collapsible section behavior to use defines (COLLAPSIBLE, SEC_OPEN, ↵Stephen Beaver2015-12-031-4/+7
| | | | SEC_CLOSED)
* SpellingStephen Beaver2015-12-031-4/+4
|
* Further changes to Section.class.php and to diag_logs_filter.phpStephen Beaver2015-12-031-2/+8
| | | | | | | | | | Experimental section collapse Form_Section() now accepts up to 4 arguments: Form_section(title, id, collapsable, initiall_collapsed) collapsable = true specifies that the panel should be collapsable and should have a plus/minus icon in the title bar to allow that. Defaults to false A unique ID is required when collapsable is specified (per page) so we know which panel to collapse If initially_collapsed is true, the panel starts out collapsed (defaults to false)
* Add full classpath to autoloader so that packages can run from their own ↵Stephen Beaver2015-12-021-1/+1
| | | | directories.
* Experimental changes to Form_Section() to allow the panel to be made ↵Stephen Beaver2015-12-011-3/+16
| | | | | | collapsable in the same way that dashboard widgets are. Currently used on diag_logs_filter.php ONLY
* Update Form_Input flassColin Fleming2015-11-291-1/+1
|
* Added use of class autoloading (GUI stuff only)Doug Wollison2015-11-233-7/+12
| | | | | Any GUI script that loads the guiconfig.inc file will have access to the autoloader.
* add attribute 'id' for the Form_Sectionbruno2015-11-191-2/+5
|
* Allow fa icons to be embedded in Form_Button class buttonsStephen Beaver2015-11-092-3/+28
|
* Initial conversion of the file. Most functions completed and tested, but ↵Stephen Beaver2015-09-251-0/+17
| | | | more testing remains
* Fixed #5121Stephen Beaver2015-09-181-3/+10
| | | | Obscure PHP issue with mixed variable types.
* Revised all pages with autocomplete to accommodate host names in validation ↵Stephen Beaver2015-09-111-1/+1
| | | | and change port inputs to 'text'
* Fixed Modal class issuesStephen Beaver2015-09-091-2/+2
| | | | | FInished interfaces.php (probably) Fixed notices error in head.inc
* Fixed modal.class.php so that modal forms now workStephen Beaver2015-09-081-1/+1
| | | | interface.php changes still WIP
* Fixed #5102Stephen Beaver2015-09-081-15/+3
| | | | javascript revised to accommodate VPN masks
* Fixed #5102Stephen Beaver2015-09-041-0/+13
| | | | Provided new method addVPNMask() that creates a mask selector including '0'
OpenPOWER on IntegriCloud