| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't call gettext with an empty title.
There are undoubtedly other places that a check should be done before passing a variable only to a gettext call.
Fixes use case of form group class without a title from passing empty var to gettext.
Gettext returns header info. when an empty string/var is passed.
Perhaps a function should be created for this for consistency.
http://php.net/manual/en/function.gettext.php#108594
For groups without a title gettext returns header info.
To reproduce the issue select a non English language and open any of the following:
Services Load Balancer - edit
Diagnostics - Backup/Restore
Diagnostics - Status SMART
Status - System Logs - log filter and manage log panels
(not a comprehensive list)
|
|
|
|
| |
and Chromium
|
|
|
|
| |
inconsistent handling of checkboxes in packages.
|
|
|
|
|
| |
renamed get_type to getType
fix capitalisation in getTagName
|
|
|
|
| |
packages.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The name attribute is obsolete. Consider putting an id attribute on the nearest container instead.
The <a> name attribute is not supported in HTML5. Use the id attribute instead.
|
|
|
|
| |
but it might as well work just in case.
|
| |
|
| |
|
|
|
|
| |
Added new functionality to PHP classes, and used it ONLY in system_advanced_notifications.php -> smtp password
|
| |
|
|\ |
|
| |
| |
| |
| |
| | |
This is a combined version of:
https://github.com/pfsense/pfsense/pull/2310
https://github.com/pfsense/pfsense/pull/2315
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| | |
Attribute placeholder not allowed on element select at this point.
Attribute placeholder is only allowed when the input type is email, number, password, search, tel, text, or url.
|
| |
| |
| |
| | |
Use setCols() to override
|
| |
| |
| |
| | |
attribute to take effect. Required bu pkg_edit.php and by wizards
|
| | |
|
| | |
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Touch Screen Usability Annoyance
https://forum.pfsense.org/index.php?topic=104135.0
Clicking the labels in the left column selects/activates the first item. This is the perfectly natural place for scrolling with thumb.
No big problem really for input fields, but check boxes and buttons are inadvertently selected/toggled resulting in unintended configuration changes.
Would be real nice if the labels in the left column were not "active".
This commit provides an option in System - General Setup page to enable/disable this "feature".
There is probably a better way, but this appears to be functional. For now at least it seems to work for me anyway. Just have to eliminate (null) the for attribute on the group labels so it doesn't have a target.
|
| |
| |
| |
| | |
The for attribute of the label element must refer to a non-hidden form control.
|
|/
|
|
| |
Element option without attribute label must not be empty.
|
|
|
|
| |
multiply, and also breaks multi-parameter query strings that are delimited with ampersands.
|
|
|
|
|
|
| |
define(COLLAPSIBLE, 0x08);
define(SEC_CLOSED, 0x04);
define(SEC_OPEN, 0x00);
|
|\
| |
| |
| | |
NOYB/HTML_Compliance_-_Collapsible_Form_Section_HREF
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bad value for attribute href on element a: Illegal character in fragment: not a URL code point.
<a data-toggle="collapse" href="#<id> .panel-body">
Syntax of URL:Any URL. For example: /hello, #canvas, or http://example.org/. Characters should be represented in NFC and spaces should be escaped as %20.
Fix is to set an id on the target.
|
|\ \
| | |
| | |
| | | |
NOYB/HTML_Compliance_-_Checkbox_Display_As_Radio_Unique_ID
|
| |/
| |
| |
| |
| |
| |
| |
| | |
Ensure checkbox display as raido has unique id.
Allow an id to be passed in displayAsRadio() as argument[0].
If no argument is passed, construct id as name_value:uniqid.
Previous behavior was id = name. So all the radio buttons of the set had same id.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix Empty Form Action Attribute Violation
An empty form action attribute is an HTML4 and HTML5 specification violation.
http://www.w3.org/TR/html5/forms.html#attr-fs-action
"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces."
The HTML4 specification requires that the form action attribute be present and contain a valid URI. Empty is not a valid URI.
Though an empty form action attribute may currently function there is no guarantee it will continue to do so in the future or to do so as xpected. Since it does not adhere to the specification it is left open for each browser to handle in any way they choose. And to change that behavior at any time for any reason.
Populating the form action attribute with the current URI covers both HTML4 and HTML5 specifications.
Don't leave it open to browser interpretation. Give explicit instructions to the browser by adhering to the specification.
|
|
|
|
| |
SEC_CLOSED)
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Experimental section collapse
Form_Section() now accepts up to 4 arguments: Form_section(title, id, collapsable, initiall_collapsed)
collapsable = true specifies that the panel should be collapsable and should have a plus/minus icon in the title bar to allow that. Defaults to false
A unique ID is required when collapsable is specified (per page) so we know which panel to collapse
If initially_collapsed is true, the panel starts out collapsed (defaults to false)
|
|
|
|
| |
directories.
|
|
|
|
|
|
| |
collapsable in the same way that dashboard widgets are.
Currently used on diag_logs_filter.php ONLY
|
| |
|
|
|
|
|
| |
Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.
|
| |
|
| |
|
|
|
|
| |
more testing remains
|
|
|
|
| |
Obscure PHP issue with mixed variable types.
|
|
|
|
| |
and change port inputs to 'text'
|
|
|
|
|
| |
FInished interfaces.php (probably)
Fixed notices error in head.inc
|
|
|
|
| |
interface.php changes still WIP
|
|
|
|
| |
javascript revised to accommodate VPN masks
|
|
|
|
| |
Provided new method addVPNMask() that creates a mask selector including '0'
|