XHTML Compliance - System Menu

Enforce select option

4 files changed, 48 insertions, 10 deletions

diff --git a/usr/local/www/system_advanced_admin.php b/usr/local/www/system_advanced_admin.php
index 5390ee9..39c0423 100644
--- a/usr/local/www/system_advanced_admin.php
+++ b/usr/local/www/system_advanced_admin.php
@@ -355,13 +355,18 @@ function prot_change() {
 								<td width="78%" class="vtable">
 									<select name="ssl-certref" id="ssl-certref" class="formselect">
 										<?php
+											$rowIndex = 0;
 											foreach($a_cert as $cert):
 												$selected = "";
 												if ($pconfig['ssl-certref'] == $cert['refid'])
 													$selected = "selected=\"selected\"";
+												$rowIndex++;
 										?>
 										<option value="<?=$cert['refid'];?>" <?=$selected;?>><?=$cert['descr'];?></option>
-										<?php endforeach; ?>
+										<?php endforeach;
+										if ($rowIndex == 0)
+											echo "<option></option>";
+										?>
 									</select>
 								</td>
 							</tr>
diff --git a/usr/local/www/system_advanced_firewall.php b/usr/local/www/system_advanced_firewall.php
index 60d1f04..48e0de4 100644
--- a/usr/local/www/system_advanced_firewall.php
+++ b/usr/local/www/system_advanced_firewall.php
@@ -537,10 +537,15 @@ function update_description(itemnum) {
 									<select name="tftpinterface[]" multiple="multiple" class="formselect" size="3">
 <?php
 										$ifdescs = get_configured_interface_with_descr();
+										$rowIndex = 0;
 										foreach ($ifdescs as $ifent => $ifdesc):
+											$rowIndex++;
 ?>
 											<option value="<?=$ifent;?>" <?php if (in_array($ifent, $pconfig['tftpinterface'])) echo "selected=\"selected\""; ?>><?=gettext($ifdesc);?></option>
-<?php									endforeach; ?>
+<?php									endforeach;
+										if ($rowIndex == 0)
+											echo "<option></option>";
+ ?>
 									</select>
 									<strong><?=gettext("Choose the interfaces where you want TFTP proxy helper to be enabled.");?></strong>
 								</td>
diff --git a/usr/local/www/system_crlmanager.php b/usr/local/www/system_crlmanager.php
index 099a6e1..08a9c31 100644
--- a/usr/local/www/system_crlmanager.php
+++ b/usr/local/www/system_crlmanager.php
@@ -304,15 +304,20 @@ function method_change() {
 							<td width="78%" class="vtable">
 								<select name='method' id='method' class="formselect" onchange='method_change()'>
 								<?php
+									$rowIndex = 0;
 									foreach($crl_methods as $method => $desc):
 									if (($_GET['importonly'] == "yes") && ($method != "existing"))
 										continue;
 									$selected = "";
 									if ($pconfig['method'] == $method)
 										$selected = "selected=\"selected\"";
+									$rowIndex++;
 								?>
 									<option value="<?=$method;?>" <?=$selected;?>><?=$desc;?></option>
-								<?php endforeach; ?>
+								<?php endforeach;
+								if ($rowIndex == 0)
+									echo "<option></option>";
+								?>
 								</select>
 							</td>
 						</tr>
@@ -328,13 +333,18 @@ function method_change() {
 							<td width="78%" class="vtable">
 								<select name='caref' id='caref' class="formselect">
 								<?php
+									$rowIndex = 0;
 									foreach($a_ca as $ca):
 									$selected = "";
 									if ($pconfig['caref'] == $ca['refid'])
 										$selected = "selected=\"selected\"";
+									$rowIndex++;
 								?>
 									<option value="<?=$ca['refid'];?>" <?=$selected;?>><?=$ca['descr'];?></option>
-								<?php endforeach; ?>
+								<?php endforeach;
+								if ($rowIndex == 0)
+									echo "<option></option>";
+								?>
 								</select>
 							</td>
 						</tr>
@@ -493,15 +503,23 @@ function method_change() {
 					<tr>
 						<td class="listlr" colspan="3" align="center">
 							<b><?php echo gettext("Choose a Certificate to Revoke"); ?></b>: <select name='certref' id='certref' class="formselect">
-				<?php	foreach($ca_certs as $cert): ?>
+				<?php	$rowIndex = 0;
+						foreach($ca_certs as $cert): 
+							$rowIndex++; ?>
 							<option value="<?=$cert['refid'];?>"><?=htmlspecialchars($cert['descr'])?></option>
-				<?php	endforeach; ?>
+				<?php	endforeach;
+						if ($rowIndex == 0)
+							echo "<option></option>"; ?>
 							</select>
 							<b><?php echo gettext("Reason");?></b>:
 							<select name='crlreason' id='crlreason' class="formselect">
-				<?php	foreach($openssl_crl_status as $code => $reason): ?>
+				<?php	$rowIndex = 0;
+						foreach($openssl_crl_status as $code => $reason): 
+							$rowIndex++; ?>
 							<option value="<?= $code ?>"><?= htmlspecialchars($reason) ?></option>
-				<?php	endforeach; ?>
+				<?php	endforeach;
+						if ($rowIndex == 0)
+							echo "<option></option>"; ?>
 							</select>
 							<input name="act" type="hidden" value="addcert" />
 							<input name="crlref" type="hidden" value="<?=$crl['refid'];?>" />
diff --git a/usr/local/www/system_usermanager.php b/usr/local/www/system_usermanager.php
index a844922..563a73b 100644
--- a/usr/local/www/system_usermanager.php
+++ b/usr/local/www/system_usermanager.php
@@ -728,12 +728,17 @@ function sshkeyClicked(obj) {
                                                         	<td width="78%" class="vtable">
                                                                 	<select name='caref' id='caref' class="formselect" onchange='internalca_change()'>
                                                                 <?php
+																		$rowIndex = 0;
                                                                         foreach( $config['ca'] as $ca):
                                                                         if (!$ca['prv'])
                                                                                 continue;
+																			$rowIndex++;
                                                                 ?>
                                                                         <option value="<?=$ca['refid'];?>"><?=$ca['descr'];?></option>
-                                                                <?php endforeach; ?>
+                                                                <?php endforeach;
+																if ($rowIndex == 0)
+																	echo "<option></option>";
+																?>
                                                                 	</select>
                                                         	</td>
                                                 	</tr>
@@ -743,10 +748,15 @@ function sshkeyClicked(obj) {
                                                                 	<select name='keylen' class="formselect">
                                                                 <?php
 									$cert_keylens = array( "2048", "512", "1024", "4096");
+																		$rowIndex = 0;
                                                                         foreach( $cert_keylens as $len):
+																			$rowIndex++;
                                                                 ?>
                                                                         <option value="<?=$len;?>"><?=$len;?></option>
-                                                                <?php endforeach; ?>
+                                                                <?php endforeach;
+																if ($rowIndex == 0)
+																	echo "<option></option>";
+																?>
                                                                 	</select>
                                                                 	bits
                                                         	</td>