diff options
| author | Colin Fleming <cj_fleming@sky.com> | 2013-04-03 20:57:46 +0100 |
|---|---|---|
| committer | Colin Fleming <cj_fleming@sky.com> | 2013-04-03 20:57:46 +0100 |
| commit | dcdff6fad95cb11fad86b848dc2045e2b2068c4f (patch) | |
| tree | 565a60227255986bb59ed6bab52d9ad4054b9abc /usr/local/www/system_routes_edit.php | |
| parent | cd4a47d899d01a4037f0e0d0428a05a58e855409 (diff) | |
| download | pfsense-dcdff6fad95cb11fad86b848dc2045e2b2068c4f.zip pfsense-dcdff6fad95cb11fad86b848dc2045e2b2068c4f.tar.gz | |
Tidy up "system_routes_edit.php" XHTML
Close INPUT, BR and IMG tags and add alt to IMG tags
Update HTML boolean operators
Remove name statements from DIV tags
Add missing end TD, end TR and end FONT tags
Add CDATA sections to SCRIPT tags
Diffstat (limited to 'usr/local/www/system_routes_edit.php')
| -rwxr-xr-x | usr/local/www/system_routes_edit.php | 75 |
1 files changed, 35 insertions, 40 deletions
diff --git a/usr/local/www/system_routes_edit.php b/usr/local/www/system_routes_edit.php index 673eb7f..278001a 100755 --- a/usr/local/www/system_routes_edit.php +++ b/usr/local/www/system_routes_edit.php @@ -220,31 +220,29 @@ include("head.inc"); <body link="#0000CC" vlink="#0000CC" alink="#0000CC"> <script type="text/javascript" src="/javascript/jquery.ipv4v6ify.js"></script> -<script type="text/javascript" src="/javascript/autosuggest.js"> -</script> -<script type="text/javascript" src="/javascript/suggestions.js"> -</script> +<script type="text/javascript" src="/javascript/autosuggest.js"></script> +<script type="text/javascript" src="/javascript/suggestions.js"></script> <?php include("fbegin.inc");?> <?php if ($input_errors) print_input_errors($input_errors); ?> <form action="system_routes_edit.php" method="post" name="iform" id="iform"> - <table width="100%" border="0" cellpadding="6" cellspacing="0"> + <table width="100%" border="0" cellpadding="6" cellspacing="0" summary="system routes edit"> <tr> <td colspan="2" valign="top" class="listtopic"><?=gettext("Edit route entry"); ?></td> </tr> <tr> <td width="22%" valign="top" class="vncellreq"><?=gettext("Destination network"); ?></td> <td width="78%" class="vtable"> - <input name="network" type="text" class="formfldalias ipv4v6" id="network" size="20" value="<?=htmlspecialchars($pconfig['network']);?>"> + <input name="network" type="text" class="formfldalias ipv4v6" id="network" size="20" value="<?=htmlspecialchars($pconfig['network']);?>" /> / - <select name="network_subnet" class="formselect ipv4v6" id="network_subnet" + <select name="network_subnet" class="formselect ipv4v6" id="network_subnet"> <?php for ($i = 129; $i >= 1; $i--): ?> - <option value="<?=$i;?>" <?php if ($i == $pconfig['network_subnet']) echo "selected"; ?>> + <option value="<?=$i;?>" <?php if ($i == $pconfig['network_subnet']) echo "selected=\"selected\""; ?>> <?=$i;?> </option> <?php endfor; ?> </select> - <br> <span class="vexpl"><?=gettext("Destination network for this static route"); ?></span></td> + <br/><span class="vexpl"><?=gettext("Destination network for this static route"); ?></span></td> </tr> <tr> <td width="22%" valign="top" class="vncellreq"><?=gettext("Gateway"); ?></td> @@ -254,32 +252,31 @@ include("head.inc"); foreach ($a_gateways as $gateway) { echo "<option value='{$gateway['name']}' "; if ($gateway['name'] == $pconfig['gateway']) - echo "selected"; + echo "selected=\"selected\""; echo ">" . htmlspecialchars($gateway['name']) . " - " . htmlspecialchars($gateway['gateway']) . "</option>\n"; } ?> </select> <br /> <div id='addgwbox'> - <?=gettext("Choose which gateway this route applies to or"); ?> <a OnClick="show_add_gateway();" href="#"><?=gettext("add a new one.");?></a> + <?=gettext("Choose which gateway this route applies to or"); ?> <a onclick="show_add_gateway();" href="#"><?=gettext("add a new one.");?></a> </div> <div id='notebox'> </div> - <div style="display:none" name ="status" id="status"> + <div style="display:none" id="status"> </div> - <div style="display:none" id="addgateway" name="addgateway"> - <p> - <table border="1" style="background:#990000; border-style: none none none none; width:225px;"><tr><td> - <table bgcolor="#990000" cellpadding="1" cellspacing="1"> - <tr><td> </td> + <div style="display:none" id="addgateway"> + <table border="1" style="background:#990000; border-style: none none none none; width:225px;" summary="add gateway"><tr><td> + <table bgcolor="#990000" cellpadding="1" cellspacing="1" summary="add"> + <tr><td> </td></tr> <tr> - <td colspan="2"><center><b><font color="white"><?=gettext("Add new gateway:"); ?></b></center></td> + <td colspan="2" align="center"><b><font color="white"><?=gettext("Add new gateway:"); ?></font></b></td> </tr> - <tr><td> </td> + <tr><td> </td></tr> <tr> - <td width="45%" align="right"><font color="white"><?=gettext("Default gateway:"); ?></td><td><input type="checkbox" id="defaultgw" name="defaultgw"></td> + <td width="45%" align="right"><font color="white"><?=gettext("Default gateway:"); ?></font></td><td><input type="checkbox" id="defaultgw" name="defaultgw" /></td> </tr> <tr> - <td width="45%" align="right"><font color="white"><?=gettext("Interface:"); ?></td> + <td width="45%" align="right"><font color="white"><?=gettext("Interface:"); ?></font></td> <td><select name="addinterfacegw" id="addinterfacegw"> <?php $gwifs = get_configured_interface_with_descr(); foreach($gwifs as $fif => $dif) @@ -288,36 +285,33 @@ include("head.inc"); </select></td> </tr> <tr> - <td align="right"><font color="white"><?=gettext("Gateway Name:"); ?></td><td><input id="name" name="name" value="GW"></td> + <td align="right"><font color="white"><?=gettext("Gateway Name:"); ?></font></td><td><input id="name" name="name" value="GW" /></td> </tr> <tr> - <td align="right"><font color="white"><?=gettext("Gateway IP:"); ?></td><td><input id="gatewayip" name="gatewayip"></td> + <td align="right"><font color="white"><?=gettext("Gateway IP:"); ?></font></td><td><input id="gatewayip" name="gatewayip" /></td> </tr> <tr> - <td align="right"><font color="white"><?=gettext("Description:"); ?></td><td><input id="gatewaydescr" name="gatewaydescr"></td> + <td align="right"><font color="white"><?=gettext("Description:"); ?></font></td><td><input id="gatewaydescr" name="gatewaydescr" /></td> </tr> - <tr><td> </td> + <tr><td> </td></tr> <tr> - <td colspan="2"> - <center> + <td colspan="2" align="center"> <div id='savebuttondiv'> <input type="hidden" name="addrtype" id="addrtype" value="IPv4" /> - <input id="gwsave" type="Button" value="<?=gettext("Save Gateway"); ?>" onClick='hide_add_gatewaysave();'> - <input id="gwcancel" type="Button" value="<?=gettext("Cancel"); ?>" onClick='hide_add_gateway();'> + <input id="gwsave" type="button" value="<?=gettext("Save Gateway"); ?>" onclick='hide_add_gatewaysave();' /> + <input id="gwcancel" type="button" value="<?=gettext("Cancel"); ?>" onclick='hide_add_gateway();' /> </div> - </center> </td> </tr> - <tr><td> </td> + <tr><td> </td></tr> </table> </td></tr></table> - <p/> </div> - </tr> + </td></tr> <tr> <td width="22%" valign="top" class="vncell"><?=gettext("Disabled");?></td> <td width="78%" class="vtable"> - <input name="disabled" type="checkbox" id="disabled" value="yes" <?php if ($pconfig['disabled']) echo "checked"; ?>> + <input name="disabled" type="checkbox" id="disabled" value="yes" <?php if ($pconfig['disabled']) echo "checked=\"checked\""; ?> /> <strong><?=gettext("Disable this static route");?></strong><br /> <span class="vexpl"><?=gettext("Set this option to disable this static route without removing it from the list.");?></span> </td> @@ -325,21 +319,22 @@ include("head.inc"); <tr> <td width="22%" valign="top" class="vncell"><?=gettext("Description"); ?></td> <td width="78%" class="vtable"> - <input name="descr" type="text" class="formfld unknown" id="descr" size="40" value="<?=htmlspecialchars($pconfig['descr']);?>"> - <br> <span class="vexpl"><?=gettext("You may enter a description here for your reference (not parsed)."); ?></span></td> + <input name="descr" type="text" class="formfld unknown" id="descr" size="40" value="<?=htmlspecialchars($pconfig['descr']);?>" /> + <br/><span class="vexpl"><?=gettext("You may enter a description here for your reference (not parsed)."); ?></span></td> </tr> <tr> <td width="22%" valign="top"> </td> <td width="78%"> - <input id="save" name="Submit" type="submit" class="formbtn" value="<?=gettext("Save");?>"> <input id="cancel" type="button" value="<?=gettext("Cancel"); ?>" class="formbtn" onclick="history.back()"> + <input id="save" name="Submit" type="submit" class="formbtn" value="<?=gettext("Save");?>" /> <input id="cancel" type="button" value="<?=gettext("Cancel"); ?>" class="formbtn" onclick="history.back()" /> <?php if (isset($id) && $a_routes[$id]): ?> - <input name="id" type="hidden" value="<?=htmlspecialchars($id);?>"> + <input name="id" type="hidden" value="<?=htmlspecialchars($id);?>" /> <?php endif; ?> </td> </tr> </table> </form> <script type="text/javascript"> +//<![CDATA[ var gatewayip; var name; function show_add_gateway() { @@ -390,7 +385,7 @@ include("head.inc"); optn.value = value; selectbox.append(optn); selectbox.prop('selectedIndex',selectbox.children('option').length-1); - jQuery('#notebox').html("<p/><strong><?=gettext("NOTE:");?></strong> <?php printf(gettext("You can manage Gateways %shere%s."), "<a target='_new' href='system_gateways.php'>", "</a>");?> </strong>"); + jQuery('#notebox').html("<p><strong><?=gettext("NOTE:");?><\/strong> <?php printf(gettext("You can manage Gateways %shere%s."), "<a target='_blank' href='system_gateways.php'>", "<\/a>");?> <\/strong><\/p>"); } function report_failure() { alert("<?=gettext("Sorry, we could not create your gateway at this time."); ?>"); @@ -409,7 +404,7 @@ include("head.inc"); } var addressarray = <?= json_encode(get_alias_list(array("host", "network"))) ?>; var oTextbox1 = new AutoSuggestControl(document.getElementById("network"), new StateSuggestions(addressarray)); - +//]]> </script> <?php include("fend.inc"); ?> </body> |
