diff options
| author | Colin Fleming <cj_fleming@sky.com> | 2014-05-16 21:12:58 +0100 |
|---|---|---|
| committer | Colin Fleming <cj_fleming@sky.com> | 2014-05-16 21:12:58 +0100 |
| commit | 0cb6064557e1d762ae4892bcb715a27dd0bcbac7 (patch) | |
| tree | ca0b8c96aae124522f2570468720a08c3ce2ee91 /usr/local/www/status_captiveportal.php | |
| parent | 024068017f98572f6bd41b7ba542fc36fccee39a (diff) | |
| download | pfsense-0cb6064557e1d762ae4892bcb715a27dd0bcbac7.zip pfsense-0cb6064557e1d762ae4892bcb715a27dd0bcbac7.tar.gz | |
Tidy up "status_captiveportal" XHTML
Add SUMMARY to TABLES
Remove PHP ECHO that isn't in a PHP statement
Update HTML Boolean operator
Add COLSPAN to fill the width of the table
Move NOWRAP to CLASS statement
Close INPUT and IMG tags and add ALT to IMG
Add BODY between HEAD.INC and FBEGIN.INC
Remove TYPE from TEXTAREA, invalid in XHTML
Add closing BODY and closing HTML tags
Diffstat (limited to 'usr/local/www/status_captiveportal.php')
| -rw-r--r-- | usr/local/www/status_captiveportal.php | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/usr/local/www/status_captiveportal.php b/usr/local/www/status_captiveportal.php index 994445e..db5f757 100644 --- a/usr/local/www/status_captiveportal.php +++ b/usr/local/www/status_captiveportal.php @@ -117,7 +117,7 @@ $mac_man = load_mac_manufacturer_table(); <td class="tabcont"> <?php endif; ?> -<table class="tabcont" width="100%" border="0" cellpadding="0" cellspacing="0"> +<table class="tabcont" width="100%" border="0" cellpadding="0" cellspacing="0" summary="main area"> <tr> <td width="20%" class="vncell" valign="top"> <br /><?=gettext("Captive Portal Zone"); ?><br/><br /> @@ -125,11 +125,11 @@ $mac_man = load_mac_manufacturer_table(); <td class="vncell" width="30%" align="center"> <form action="status_captiveportal.php" method="post" enctype="multipart/form-data" name="form1" id="form1"> <select name="zone" class="formselect" onchange="document.form1.submit()"> - echo "<option value="">none</option>\n"; + <option value="">none</option> <?php foreach ($a_cp as $cpkey => $cp) { - echo "<option value='{$cpkey}' "; + echo "<option value=\"{$cpkey}\" "; if ($cpzone == $cpkey) - echo "selected"; + echo "selected=\"selected\""; echo ">" . htmlspecialchars($cp['zone']) . "</option>\n"; } ?> @@ -152,7 +152,7 @@ $mac_man = load_mac_manufacturer_table(); <td class="listhdrr"><a href="?zone=<?=$cpzone?>&order=start&showact=<?=htmlspecialchars($_GET['showact']);?>"><?=gettext("Session start");?></a></td> <td class="listhdr"><a href="?zone=<?=$cpzone?>&order=lastact&showact=<?=htmlspecialchars($_GET['showact']);?>"><?=gettext("Last activity");?></a></td> <?php else: ?> - <td class="listhdr"><a href="?zone=<?=$cpzone?>&order=start&showact=<?=htmlspecialchars($_GET['showact']);?>"><?=gettext("Session start");?></a></td> + <td class="listhdr" colspan="2"><a href="?zone=<?=$cpzone?>&order=start&showact=<?=htmlspecialchars($_GET['showact']);?>"><?=gettext("Session start");?></a></td> <?php endif; ?> <td class="list sort_ignore"></td> </tr> @@ -174,8 +174,10 @@ $mac_man = load_mac_manufacturer_table(); <?php if ($_GET['showact']): $last_act = captiveportal_get_last_activity($cpent[2], $cpent[3]); ?> <td class="listr"><?php if ($last_act != 0) echo htmlspecialchars(date("m/d/Y H:i:s", $last_act));?></td> + <?php else: ?> + <td class="listr" colspan="2"><?=htmlspecialchars(date("m/d/Y H:i:s", $cpent[0]));?></td> <?php endif; ?> - <td valign="middle" class="list" nowrap> + <td valign="middle" class="list nowrap"> <a href="?zone=<?=$cpzone;?>&order=<?=$_GET['order'];?>&showact=<?=htmlspecialchars($_GET['showact']);?>&act=del&id=<?=$cpent[5];?>" onclick="return confirm('<?=gettext("Do you really want to disconnect this client?");?>')"><img src="./themes/<?= $g['theme']; ?>/images/icons/icon_x.gif" width="17" height="17" border="0" title="<?=gettext("Disconnect");?>"></a> </td> </tr> |
