diff options
| author | Colin Fleming <cj_fleming@sky.com> | 2014-04-18 23:08:43 +0100 |
|---|---|---|
| committer | Colin Fleming <cj_fleming@sky.com> | 2014-04-18 23:08:43 +0100 |
| commit | d9555fc55909e70fc4df7f49a094d71fa3f3a482 (patch) | |
| tree | f20097c9b6ebfc650a949325c008245795d05c5d /usr/local/www/services_ntpd.php | |
| parent | 928dc66a4341eeb7d84d79d7a331462107863170 (diff) | |
| download | pfsense-d9555fc55909e70fc4df7f49a094d71fa3f3a482.zip pfsense-d9555fc55909e70fc4df7f49a094d71fa3f3a482.tar.gz | |
Tidy up "services_ntpd" XHTML
Add "closehead" PHP variable and manually close HEAD
Add CDATA sections to SCRIPTS
Closing IMG tag and add ALT
Change "onclick" to lower case
Add SUMMARY to tables
Close INPUT tags
Update HTML Boolean operators
Remove closing anchor tag from INPUT tag
Diffstat (limited to 'usr/local/www/services_ntpd.php')
| -rw-r--r-- | usr/local/www/services_ntpd.php | 68 |
1 files changed, 34 insertions, 34 deletions
diff --git a/usr/local/www/services_ntpd.php b/usr/local/www/services_ntpd.php index 4012ed9..f3b8c72 100644 --- a/usr/local/www/services_ntpd.php +++ b/usr/local/www/services_ntpd.php @@ -168,7 +168,7 @@ if ($_POST) { } } - +$closehead = false; $pconfig = &$config['ntpd']; $pgtitle = array(gettext("Services"),gettext("NTP")); $shortcut_section = "ntp"; @@ -177,7 +177,7 @@ include("head.inc"); ?> <script type="text/javascript"> - +//<![CDATA[ //Generic show an advanced option function function show_advanced(showboxID, configvalueID) { document.getElementById(showboxID).innerHTML=''; @@ -204,7 +204,7 @@ include("head.inc"); //then revise the add another server line if (add < 9) { var next = add + 1; - var newdiv = '<img src="/themes/<?= $g['theme']; ?>/images/icons/icon_plus.gif" width="17" height="17" border="0" title="<?php echo gettext("Add another Time server");?>" OnClick="NewTimeServer(' + next + ')">\n'; + var newdiv = '<img src="/themes/<?= $g['theme']; ?>/images/icons/icon_plus.gif" width="17" height="17" border="0" title="<?php echo gettext("Add another Time server");?>" onclick="NewTimeServer(' + next + ')" alt="add" />\n'; document.getElementById('addserver').innerHTML=newdiv; }else{ document.getElementById('addserver').style.display = 'none'; @@ -212,9 +212,9 @@ include("head.inc"); } } } - +//]]> </script> - +</head> <body link="#0000CC" vlink="#0000CC" alink="#0000CC"> <?php include("fbegin.inc"); ?> @@ -222,7 +222,7 @@ include("head.inc"); <?php if ($input_errors) print_input_errors($input_errors); ?> <?php if ($savemsg) print_info_box($savemsg); ?> -<table width="100%" border="0" cellpadding="0" cellspacing="0"> +<table width="100%" border="0" cellpadding="0" cellspacing="0" summary="ntpd"> <tr> <td> <?php @@ -237,7 +237,7 @@ include("head.inc"); <tr> <td> <div id="mainarea"> - <table class="tabcont" width="100%" border="0" cellpadding="6" cellspacing="0"> + <table class="tabcont" width="100%" border="0" cellpadding="6" cellspacing="0" summary="main area"> <tr> <td colspan="2" valign="top" class="listtopic"><?=gettext("NTP Server Configuration"); ?></td> </tr> @@ -254,7 +254,7 @@ include("head.inc"); $interfaces[$aliasip] = $aliasip." (".get_vip_descr($aliasip).")"; $size = (count($interfaces) < 10) ? count($interfaces) : 10; ?> - <select id="interface" name="interface[]" multiple="true" class="formselect" size="<?php echo $size; ?>"> + <select id="interface" name="interface[]" multiple="multiple" class="formselect" size="<?php echo $size; ?>"> <?php foreach ($interfaces as $iface => $ifacename) { if (!is_ipaddr(get_interface_ip($iface)) && !is_ipaddr($iface)) @@ -286,17 +286,17 @@ include("head.inc"); } echo ">\n"; - echo "<input name=\"server{$i}\" class=\"formfld unknown\" id=\"server{$i}\" size=\"30\" value=\"{$timeservers[$i]}\" type=\"text\"> "; - echo "\n<input name=\"servprefer{$i}\" class=\"formcheckbox\" id=\"servprefer{$i}\" OnClick=\"CheckOffOther('servprefer{$i}', 'servselect{$i}')\" type=\"checkbox\""; - if (substr_count($config['ntpd']['prefer'], $timeservers[$i])) echo ' checked'; - echo '> prefer '; - echo "\n<input name=\"servselect{$i}\" class=\"formcheckbox\" id=\"servselect{$i}\" OnClick=\"CheckOffOther('servselect{$i}', 'servprefer{$i}')\" type=\"checkbox\""; - if (substr_count($config['ntpd']['noselect'], $timeservers[$i])) echo ' checked'; - echo "> noselect\n<br />\n</div>\n"; + echo "<input name=\"server{$i}\" class=\"formfld unknown\" id=\"server{$i}\" size=\"30\" value=\"{$timeservers[$i]}\" type=\"text\" /> "; + echo "\n<input name=\"servprefer{$i}\" class=\"formcheckbox\" id=\"servprefer{$i}\" onclick=\"CheckOffOther('servprefer{$i}', 'servselect{$i}')\" type=\"checkbox\""; + if (substr_count($config['ntpd']['prefer'], $timeservers[$i])) echo " checked=\"checked\""; + echo " /> prefer "; + echo "\n<input name=\"servselect{$i}\" class=\"formcheckbox\" id=\"servselect{$i}\" onclick=\"CheckOffOther('servselect{$i}', 'servprefer{$i}')\" type=\"checkbox\""; + if (substr_count($config['ntpd']['noselect'], $timeservers[$i])) echo " checked=\"checked\""; + echo " /> noselect\n<br />\n</div>\n"; } ?> <div id="addserver"> - <img src="/themes/<?= $g['theme']; ?>/images/icons/icon_plus.gif" width="17" height="17" border="0" title="<?php echo gettext("Add another Time server");?>" OnClick="NewTimeServer(<?php echo $j;?>)"> + <img src="/themes/<?= $g['theme']; ?>/images/icons/icon_plus.gif" width="17" height="17" border="0" title="<?php echo gettext("Add another Time server");?>" onclick="NewTimeServer(<?php echo $j;?>)" alt="add" /> </div> <br /> <?php echo gettext('For best results three to five servers should be configured here.'); ?> @@ -309,14 +309,14 @@ include("head.inc"); <tr> <td width="22%" valign="top" class="vncellreq">Orphan mode</td> <td width="78%" class="vtable"> - <input name="ntporphan" type="text" class="formfld unknown" id="ntporphan" min="1" max="16" size="20" value="<?=htmlspecialchars($pconfig['orphan']);?>"><?php echo gettext("(0-15)");?><br /> + <input name="ntporphan" type="text" class="formfld unknown" id="ntporphan" min="1" max="16" size="20" value="<?=htmlspecialchars($pconfig['orphan']);?>" /><?php echo gettext("(0-15)");?><br /> <?php echo gettext("Orphan mode allows the system clock to be used when no other clocks are available. The number here specifies the stratum reported during orphan mode and should normally be set to a number high enough to insure that any other servers available to clients are preferred over this server. (default: 12)."); ?> </td> </tr> <tr> <td width="22%" valign="top" class="vncellreq">NTP graphs</td> <td width="78%" class="vtable"> - <input name="statsgraph" type="checkbox" class="formcheckbox" id="statsgraph" <?php if($pconfig['statsgraph']) echo ' checked'; ?>> + <input name="statsgraph" type="checkbox" class="formcheckbox" id="statsgraph" <?php if($pconfig['statsgraph']) echo " checked=\"checked\""; ?> /> <?php echo gettext("Enable rrd graphs of NTP statistics (default: disabled)."); ?> </td> </tr> @@ -325,10 +325,10 @@ include("head.inc"); <td width="78%" class="vtable"> <?php echo gettext("These options enable additional messages from NTP to be written to the System Log");?> (<a href="diag_logs_ntpd.php"><?php echo gettext("Status > System Logs > NTP"); ?></a>). <br /><br /> - <input name="logpeer" type="checkbox" class="formcheckbox" id="logpeer"<?php if($pconfig['logpeer']) echo ' checked'; ?>> + <input name="logpeer" type="checkbox" class="formcheckbox" id="logpeer"<?php if($pconfig['logpeer']) echo " checked=\"checked\""; ?> /> <?php echo gettext("Enable logging of peer messages (default: disabled)."); ?> <br /> - <input name="logsys" type="checkbox" class="formcheckbox" id="logsys"<?php if($pconfig['logsys']) echo ' checked'; ?>> + <input name="logsys" type="checkbox" class="formcheckbox" id="logsys"<?php if($pconfig['logsys']) echo " checked=\"checked\""; ?> /> <?php echo gettext("Enable logging of system messages (default: disabled)."); ?> </td> </tr> @@ -336,18 +336,18 @@ include("head.inc"); <td width="22%" valign="top" class="vncellreq">Statistics logging</td> <td width="78%" class="vtable"> <div id="showstatisticsbox"> - <input type="button" onClick="show_advanced('showstatisticsbox', 'showstatistics')" value="<?=gettext("Advanced");?>" /> - <?=gettext("Show statistics logging options");?></a> + <input type="button" onclick="show_advanced('showstatisticsbox', 'showstatistics')" value="<?=gettext("Advanced");?>" /> - <?=gettext("Show statistics logging options");?> </div> <div id="showstatistics" style="display:none"> <strong><?php echo gettext("Warning: ")?></strong><?php echo gettext("these options will create persistant daily log files in /var/log/ntp."); ?> <br /><br /> - <input name="clockstats" type="checkbox" class="formcheckbox" id="clockstats"<?php if($pconfig['clockstats']) echo ' checked'; ?>> + <input name="clockstats" type="checkbox" class="formcheckbox" id="clockstats"<?php if($pconfig['clockstats']) echo " checked=\"checked\""; ?> /> <?php echo gettext("Enable logging of reference clock statistics (default: disabled)."); ?> <br /> - <input name="loopstats" type="checkbox" class="formcheckbox" id="loopstats"<?php if($pconfig['loopstats']) echo ' checked'; ?>> + <input name="loopstats" type="checkbox" class="formcheckbox" id="loopstats"<?php if($pconfig['loopstats']) echo " checked=\"checked\""; ?> /> <?php echo gettext("Enable logging of clock discipline statistics (default: disabled)."); ?> <br /> - <input name="peerstats" type="checkbox" class="formcheckbox" id="peerstats"<?php if($pconfig['peerstats']) echo ' checked'; ?>> + <input name="peerstats" type="checkbox" class="formcheckbox" id="peerstats"<?php if($pconfig['peerstats']) echo " checked=\"checked\""; ?> /> <?php echo gettext("Enable logging of NTP peer statistics (default: disabled)."); ?> </div> </td> @@ -356,27 +356,27 @@ include("head.inc"); <td width="22%" valign="top" class="vncellreq">Access restrictions</td> <td width="78%" class="vtable"> <div id="showrestrictbox"> - <input type="button" onClick="show_advanced('showrestrictbox', 'showrestrict')" value="<?=gettext("Advanced");?>" /> - <?=gettext("Show access restriction options");?></a> + <input type="button" onclick="show_advanced('showrestrictbox', 'showrestrict')" value="<?=gettext("Advanced");?>" /> - <?=gettext("Show access restriction options");?> </div> <div id="showrestrict" style="display:none"> <?php echo gettext("these options control access to NTP from the WAN."); ?> <br /><br /> - <input name="kod" type="checkbox" class="formcheckbox" id="kod"<?php if(!$pconfig['kod']) echo ' checked'; ?>> + <input name="kod" type="checkbox" class="formcheckbox" id="kod"<?php if(!$pconfig['kod']) echo " checked=\"checked\""; ?> /> <?php echo gettext("Enable Kiss-o'-death packets (default: enabled)."); ?> <br /> - <input name="nomodify" type="checkbox" class="formcheckbox" id="nomodify"<?php if(!$pconfig['nomodify']) echo ' checked'; ?>> + <input name="nomodify" type="checkbox" class="formcheckbox" id="nomodify"<?php if(!$pconfig['nomodify']) echo " checked=\"checked\""; ?> /> <?php echo gettext("Deny state modifications (i.e. run time configuration) by ntpq and ntpdc (default: enabled)."); ?> <br /> - <input name="noquery" type="checkbox" class="formcheckbox" id="noquery"<?php if($pconfig['noquery']) echo ' checked'; ?>> + <input name="noquery" type="checkbox" class="formcheckbox" id="noquery"<?php if($pconfig['noquery']) echo " checked=\"checked\""; ?> />> <?php echo gettext("Disable ntpq and ntpdc queries (default: disabled)."); ?> <br /> - <input name="noserve" type="checkbox" class="formcheckbox" id="noserve"<?php if($pconfig['noserve']) echo ' checked'; ?>> + <input name="noserve" type="checkbox" class="formcheckbox" id="noserve"<?php if($pconfig['noserve']) echo " checked=\"checked\""; ?> /> <?php echo gettext("Disable all except ntpq and ntpdc queries (default: disabled)."); ?> <br /> - <input name="nopeer" type="checkbox" class="formcheckbox" id="nopeer"<?php if(!$pconfig['nopeer']) echo ' checked'; ?>> + <input name="nopeer" type="checkbox" class="formcheckbox" id="nopeer"<?php if(!$pconfig['nopeer']) echo " checked=\"checked\""; ?> /> <?php echo gettext("Deny packets that attempt a peer association (default: enabled)."); ?> <br /> - <input name="notrap" type="checkbox" class="formcheckbox" id="notrap"<?php if(!$pconfig['notrap']) echo ' checked'; ?>> + <input name="notrap" type="checkbox" class="formcheckbox" id="notrap"<?php if(!$pconfig['notrap']) echo " checked=\"checked\""; ?> /> <?php echo gettext("Deny mode 6 control message trap service (default: enabled)."); ?> </div> </td> @@ -385,7 +385,7 @@ include("head.inc"); <td width="22%" valign="top" class="vncellreq">Leap seconds</td> <td width="78%" class="vtable"> <div id="showleapsecbox"> - <input type="button" onClick="show_advanced('showleapsecbox', 'showleapsec')" value="<?=gettext("Advanced");?>" /> - <?=gettext("Show Leap second configuration");?></a> + <input type="button" onclick="show_advanced('showleapsecbox', 'showleapsec')" value="<?=gettext("Advanced");?>" /> - <?=gettext("Show Leap second configuration");?> </div> <div id="showleapsec" style="display:none"> <?php echo gettext("A leap second file allows NTP to advertize an upcoming leap second addition or subtraction.");?> @@ -394,14 +394,14 @@ include("head.inc"); <?php echo gettext("Enter Leap second configuration as text:");?><br /> <textarea name="leaptxt" class="formpre" id="leaptxt" cols="65" rows="7"><?php $text = base64_decode(chunk_split($pconfig['leapsec'])); echo $text;?></textarea><br /> <strong><?php echo gettext("Or");?></strong>, <?php echo gettext("select a file to upload:");?> - <input type="file" name="leapfile" class="formfld file" id="leapfile"> + <input type="file" name="leapfile" class="formfld file" id="leapfile" /> </div> </td> </tr> <tr> <td width="22%" valign="top"> </td> <td width="78%"> - <input name="Submit" type="submit" class="formbtn" value="<?=gettext("Save");?>"> + <input name="Submit" type="submit" class="formbtn" value="<?=gettext("Save");?>" /> </td> </tr> </table> |
