Code style services dyndns

1 files changed, 140 insertions, 117 deletions

diff --git a/usr/local/www/services_dyndns.php b/usr/local/www/services_dyndns.php
index 6d2f678..5051f00 100644
--- a/usr/local/www/services_dyndns.php
+++ b/usr/local/www/services_dyndns.php
@@ -42,8 +42,9 @@
 
 require("guiconfig.inc");
 
-if (!is_array($config['dyndnses']['dyndns']))
+if (!is_array($config['dyndnses']['dyndns'])) {
 	$config['dyndnses']['dyndns'] = array();
+}
 
 $a_dyndns = &$config['dyndnses']['dyndns'];
 
@@ -70,135 +71,157 @@ include("head.inc");
 <form action="services_dyndns.php" method="post" name="iform" id="iform">
 <?php if ($input_errors) print_input_errors($input_errors); ?>
 <table width="100%" border="0" cellpadding="0" cellspacing="0" summary="dynamic dns">
-  <tr>
-	<td>
+	<tr>
+		<td>
 <?php
 	$tab_array = array();
 	$tab_array[] = array(gettext("DynDns"), true, "services_dyndns.php");
 	$tab_array[] = array(gettext("RFC 2136"), false, "services_rfc2136.php");
 	display_top_tabs($tab_array);
 ?>
-	</td>
-  </tr>
-  <tr>
-	<td>
-	  <div id="mainarea">
-	  <table class="tabcont" width="100%" border="0" cellpadding="0" cellspacing="0" summary="main area">
-		<tr>
-		  <td width="5%"  class="listhdrr"><?=gettext("Interface");?></td>
-		  <td width="15%" class="listhdrr"><?=gettext("Service");?></td>
-		  <td width="20%" class="listhdrr"><?=gettext("Hostname");?></td>
-		  <td width="20%" class="listhdrr"><?=gettext("Cached IP");?></td>
-		  <td width="50%" class="listhdr"><?=gettext("Description");?></td>
-		  <td width="10%" class="list"></td>
-		</tr>
-		<?php $i = 0; foreach ($a_dyndns as $dyndns): ?>
-		<tr ondblclick="document.location='services_dyndns_edit.php?id=<?=$i;?>'">
-		  <td class="listlr">
-		  <?php	$iflist = get_configured_interface_with_descr();
-			foreach ($iflist as $if => $ifdesc) {
-				if ($dyndns['interface'] == $if) {
-					if (!isset($dyndns['enable']))
-						echo "<span class=\"gray\">{$ifdesc}</span>";
-					else
-						echo "{$ifdesc}";
-					break;
+		</td>
+	</tr>
+	<tr>
+		<td>
+			<div id="mainarea">
+			<table class="tabcont" width="100%" border="0" cellpadding="0" cellspacing="0" summary="main area">
+				<tr>
+					<td width="5%"  class="listhdrr"><?=gettext("Interface");?></td>
+					<td width="15%" class="listhdrr"><?=gettext("Service");?></td>
+					<td width="20%" class="listhdrr"><?=gettext("Hostname");?></td>
+					<td width="20%" class="listhdrr"><?=gettext("Cached IP");?></td>
+					<td width="50%" class="listhdr"><?=gettext("Description");?></td>
+					<td width="10%" class="list"></td>
+				</tr>
+<?php
+	$i = 0;
+	foreach ($a_dyndns as $dyndns):
+?>
+				<tr ondblclick="document.location='services_dyndns_edit.php?id=<?=$i;?>'">
+					<td class="listlr">
+<?php
+		$iflist = get_configured_interface_with_descr();
+		foreach ($iflist as $if => $ifdesc) {
+			if ($dyndns['interface'] == $if) {
+				if (!isset($dyndns['enable'])) {
+					echo "<span class=\"gray\">{$ifdesc}</span>";
+				} else {
+					echo "{$ifdesc}";
 				}
+				break;
 			}
-			$groupslist = return_gateway_groups_array();
-			foreach ($groupslist as $if => $group) {
-				if ($dyndns['interface'] == $if) {
-					if (!isset($dyndns['enable']))
-						echo "<span class=\"gray\">{$if}</span>";
-					else
-						echo "{$if}";
-					break;
+		}
+		$groupslist = return_gateway_groups_array();
+		foreach ($groupslist as $if => $group) {
+			if ($dyndns['interface'] == $if) {
+				if (!isset($dyndns['enable'])) {
+					echo "<span class=\"gray\">{$if}</span>";
+				} else {
+					echo "{$if}";
 				}
+				break;
 			}
-		  ?>
-		  </td>
-		  <td class="listr">
-		  <?php
-			$types = explode(",", DYNDNS_PROVIDER_DESCRIPTIONS);
-			$vals = explode(" ", DYNDNS_PROVIDER_VALUES);
-			for ($j = 0; $j < count($vals); $j++)
-				if ($vals[$j] == $dyndns['type']) {
-					if (!isset($dyndns['enable']))
-						echo "<span class=\"gray\">" . htmlspecialchars($types[$j]) . "</span>";
-					else
-						echo htmlspecialchars($types[$j]);
-					break;
+		}
+?>
+					</td>
+					<td class="listr">
+<?php
+		$types = explode(",", DYNDNS_PROVIDER_DESCRIPTIONS);
+		$vals = explode(" ", DYNDNS_PROVIDER_VALUES);
+		for ($j = 0; $j < count($vals); $j++) {
+			if ($vals[$j] == $dyndns['type']) {
+				if (!isset($dyndns['enable'])) {
+					echo "<span class=\"gray\">" . htmlspecialchars($types[$j]) . "</span>";
+				} else {
+					echo htmlspecialchars($types[$j]);
 				}
-		  ?>
-		  </td>
-		  <td class="listr">
-		  <?php
-			if (!isset($dyndns['enable']))
-				echo "<span class=\"gray\">" . htmlspecialchars($dyndns['host']) . "</span>";
-			else
-				echo htmlspecialchars($dyndns['host']);
-		  ?>
-		  </td>
-		  <td class="listr">
-		  <?php
-			$filename = "{$g['conf_path']}/dyndns_{$dyndns['interface']}{$dyndns['type']}" . escapeshellarg($dyndns['host']) . "{$dyndns['id']}.cache";
-			$filename_v6 = "{$g['conf_path']}/dyndns_{$dyndns['interface']}{$dyndns['type']}" . escapeshellarg($dyndns['host']) . "{$dyndns['id']}_v6.cache";
-			if (file_exists($filename)) {
-				$ipaddr = dyndnsCheckIP($dyndns['interface']);
-				$cached_ip_s = explode(":", file_get_contents($filename));
-				$cached_ip = $cached_ip_s[0];
-				if ($ipaddr <> $cached_ip)
-					echo "<font color='red'>";
-				else
-					echo "<font color='green'>";
-				echo htmlspecialchars($cached_ip);
-				echo "</font>";
-			} else if (file_exists($filename_v6)) {
-				$ipv6addr = get_interface_ipv6($dyndns['interface']);
-				$cached_ipv6_s = explode("|", file_get_contents($filename_v6));
-				$cached_ipv6 = $cached_ipv6_s[0];
-				if ($ipv6addr <> $cached_ipv6)
-					echo "<font color='red'>";
-				else
-					echo "<font color='green'>";
-				echo htmlspecialchars($cached_ipv6);
-				echo "</font>";
+				break;
+			}
+		}
+?>
+					</td>
+					<td class="listr">
+<?php
+		if (!isset($dyndns['enable'])) {
+			echo "<span class=\"gray\">" . htmlspecialchars($dyndns['host']) . "</span>";
+		} else {
+			echo htmlspecialchars($dyndns['host']);
+		}
+?>
+					</td>
+					<td class="listr">
+<?php
+		$filename = "{$g['conf_path']}/dyndns_{$dyndns['interface']}{$dyndns['type']}" . escapeshellarg($dyndns['host']) . "{$dyndns['id']}.cache";
+		$filename_v6 = "{$g['conf_path']}/dyndns_{$dyndns['interface']}{$dyndns['type']}" . escapeshellarg($dyndns['host']) . "{$dyndns['id']}_v6.cache";
+		if (file_exists($filename)) {
+			$ipaddr = dyndnsCheckIP($dyndns['interface']);
+			$cached_ip_s = explode(":", file_get_contents($filename));
+			$cached_ip = $cached_ip_s[0];
+			if ($ipaddr <> $cached_ip) {
+				echo "<font color='red'>";
 			} else {
-				echo "N/A";
+				echo "<font color='green'>";
 			}
-		  ?>
-		  </td>
-		  <td class="listbg">
-		  <?php
-			if (!isset($dyndns['enable']))
-				echo "<span class=\"gray\">".htmlspecialchars($dyndns['descr'])."</span>";
-			else
-				echo htmlspecialchars($dyndns['descr']);
-		  ?>
-		  </td>
-		  <td valign="middle" class="list nowrap">
-			<a href="services_dyndns_edit.php?id=<?=$i;?>"><img src="./themes/<?= $g['theme']; ?>/images/icons/icon_e.gif" width="17" height="17" border="0" alt="edit" /></a>
-			&nbsp;<a href="services_dyndns.php?act=del&amp;id=<?=$i;?>" onclick="return confirm('<?=gettext("Do you really want to delete this entry?");?>')"><img src="./themes/<?= $g['theme']; ?>/images/icons/icon_x.gif" width="17" height="17" border="0" alt="delete" /></a>
-		  </td>
-		</tr>
-		<?php $i++; endforeach; ?>
-		<tr>
-		  <td class="list" colspan="5"></td>
-		  <td class="list"><a href="services_dyndns_edit.php"><img src="./themes/<?= $g['theme']; ?>/images/icons/icon_plus.gif" width="17" height="17" border="0" alt="add" /></a></td>
-		</tr>
-		<tr>
-		  <td colspan="5" class="list"><p class="vexpl"><span class="red"><strong>
-			<?=gettext("Note:");?><br />
-			</strong></span>
-			<?=gettext("IP addresses appearing in green are up to date with Dynamic DNS provider.");?><br />
-			<?=gettext("You can force an update for an IP address on the edit page for that service.");?></p>
-		  </td>
-		  <td class="list">&nbsp;</td>
-		</tr>
-	  </table>
-	  </div>
-	</td>
-  </tr>
+			echo htmlspecialchars($cached_ip);
+			echo "</font>";
+		} else if (file_exists($filename_v6)) {
+			$ipv6addr = get_interface_ipv6($dyndns['interface']);
+			$cached_ipv6_s = explode("|", file_get_contents($filename_v6));
+			$cached_ipv6 = $cached_ipv6_s[0];
+			if ($ipv6addr <> $cached_ipv6) {
+				echo "<font color='red'>";
+			} else {
+				echo "<font color='green'>";
+			}
+			echo htmlspecialchars($cached_ipv6);
+			echo "</font>";
+		} else {
+			echo "N/A";
+		}
+?>
+					</td>
+					<td class="listbg">
+<?php
+		if (!isset($dyndns['enable'])) {
+			echo "<span class=\"gray\">".htmlspecialchars($dyndns['descr'])."</span>";
+		} else {
+			echo htmlspecialchars($dyndns['descr']);
+		}
+?>
+					</td>
+					<td valign="middle" class="list nowrap">
+						<a href="services_dyndns_edit.php?id=<?=$i;?>"><img src="./themes/<?= $g['theme']; ?>/images/icons/icon_e.gif" width="17" height="17" border="0" alt="edit" /></a>
+						&nbsp;<a href="services_dyndns.php?act=del&amp;id=<?=$i;?>" onclick="return confirm('<?=gettext("Do you really want to delete this entry?");?>')"><img src="./themes/<?= $g['theme']; ?>/images/icons/icon_x.gif" width="17" height="17" border="0" alt="delete" /></a>
+					</td>
+				</tr>
+<?php
+		$i++;
+	endforeach;
+?>
+				<tr>
+					<td class="list" colspan="5"></td>
+					<td class="list">
+						<a href="services_dyndns_edit.php"><img src="./themes/<?= $g['theme']; ?>/images/icons/icon_plus.gif" width="17" height="17" border="0" alt="add" /></a>
+					</td>
+				</tr>
+				<tr>
+					<td colspan="5" class="list">
+						<p class="vexpl">
+							<span class="red">
+								<strong>
+									<?=gettext("Note:");?><br />
+								</strong>
+							</span>
+							<?=gettext("IP addresses appearing in green are up to date with Dynamic DNS provider.");?><br />
+							<?=gettext("You can force an update for an IP address on the edit page for that service.");?>
+						</p>
+					</td>
+					<td class="list">&nbsp;</td>
+				</tr>
+			</table>
+			</div>
+		</td>
+	</tr>
 </table>
 </form>
 <?php include("fend.inc"); ?>