diff options
| author | Phil Davis <phil.davis@inf.org> | 2015-04-23 20:10:30 +0545 |
|---|---|---|
| committer | Phil Davis <phil.davis@inf.org> | 2015-04-23 20:10:30 +0545 |
| commit | 48ac0aa0c6173b1bee17b137aca5f5e9f56e9051 (patch) | |
| tree | 2285ad89c702c0b6ea54ca179f7309906bf93884 /usr/local/www/services_dhcp.php | |
| parent | d6f74188816a6a3e1cb25527ecefad4a751e1237 (diff) | |
| download | pfsense-48ac0aa0c6173b1bee17b137aca5f5e9f56e9051.zip pfsense-48ac0aa0c6173b1bee17b137aca5f5e9f56e9051.tar.gz | |
Do not process dhcpd implementation if input errors
If I go to Service->DHCP Server, make some edits that are invalid (e.g. change range start or end to some invalid string) and press Save then the page comes back displaying the input error(s). But it also says:
"The changes have been applied successfully."
Actually, the changes (which were invalid) have not been applied to the config - all is well there - but dhcpd has been stopped and started and dnsmasq or unbound has been kicked... which is all unnecessary processing since the user has not yet provided valid values to save.
Diffstat (limited to 'usr/local/www/services_dhcp.php')
| -rw-r--r-- | usr/local/www/services_dhcp.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/usr/local/www/services_dhcp.php b/usr/local/www/services_dhcp.php index a92b14a..cbb5378 100644 --- a/usr/local/www/services_dhcp.php +++ b/usr/local/www/services_dhcp.php @@ -536,7 +536,7 @@ if (isset($_POST['submit'])) { } } -if (isset($_POST['submit']) || isset($_POST['apply'])) { +if ((isset($_POST['submit']) || isset($_POST['apply'])) && (!$input_errors)) { $retval = 0; $retvaldhcp = 0; $retvaldns = 0; |
