Call htmlspecialchars() to remove dangerouns chars from zone parameter. Also redirect user to services_captiveportal_zones.php when an invalid zone is passed

1 files changed, 3 insertions, 3 deletions

diff --git a/usr/local/www/services_captiveportal_zones.php b/usr/local/www/services_captiveportal_zones.php
index 5eb9742..6d956b5 100644
--- a/usr/local/www/services_captiveportal_zones.php
+++ b/usr/local/www/services_captiveportal_zones.php
@@ -50,7 +50,7 @@ if (!is_array($config['captiveportal'])) {
 $a_cp = &$config['captiveportal'];
 
 if ($_GET['act'] == "del" && !empty($_GET['zone'])) {
-	$cpzone = $_GET['zone'];
+	$cpzone = htmlspecialchars($_GET['zone']);
 	if ($a_cp[$cpzone]) {
 		$cpzoneid = $a_cp[$cpzone]['zoneid'];
 		unset($a_cp[$cpzone]['enable']);
@@ -60,9 +60,9 @@ if ($_GET['act'] == "del" && !empty($_GET['zone'])) {
 			unset($config['voucher'][$cpzone]);
 		}
 		write_config();
-		header("Location: services_captiveportal_zones.php");
-		exit;
 	}
+	header("Location: services_captiveportal_zones.php");
+	exit;
 }
 
 $pgtitle = array(gettext("Captive Portal"), gettext("Zones"));