summaryrefslogtreecommitdiffstats
path: root/usr/local/www/services_captiveportal_ip.php
diff options
context:
space:
mode:
authorErmal Luçi <eri@pfsense.org>2009-08-13 17:21:37 +0000
committerErmal Luçi <eri@pfsense.org>2009-08-13 17:21:37 +0000
commitcb0a2913cdbe02d0696b83d0de431a8e37214703 (patch)
treea372a56042e71045d184937d98beba5a4010acc8 /usr/local/www/services_captiveportal_ip.php
parentd1bd66b422f1f4cf74b7389e051b67a40237b9fe (diff)
downloadpfsense-cb0a2913cdbe02d0696b83d0de431a8e37214703.zip
pfsense-cb0a2913cdbe02d0696b83d0de431a8e37214703.tar.gz
Use ipfw tables for allowed ips. This reduces the number of rules needed for them and speedups things when this list is big. This simplifies even deleteing an allowed ip from services->captiveportal->allowedips since we just need to remove them from the table.
Diffstat (limited to 'usr/local/www/services_captiveportal_ip.php')
-rwxr-xr-xusr/local/www/services_captiveportal_ip.php25
1 files changed, 6 insertions, 19 deletions
diff --git a/usr/local/www/services_captiveportal_ip.php b/usr/local/www/services_captiveportal_ip.php
index 093c3a7..0c8983c 100755
--- a/usr/local/www/services_captiveportal_ip.php
+++ b/usr/local/www/services_captiveportal_ip.php
@@ -44,26 +44,16 @@ if (!is_array($config['captiveportal']['allowedip']))
$a_allowedips = &$config['captiveportal']['allowedip'] ;
-if ($_POST) {
-
- $pconfig = $_POST;
-
- if ($_POST['apply']) {
- $retval = 0;
-
- $retval = captiveportal_allowedip_configure();
-
- $savemsg = get_std_save_message($retval);
- if ($retval == 0)
- clear_subsystem_dirty('allowedips');
- }
-}
-
if ($_GET['act'] == "del") {
if ($a_allowedips[$_GET['id']]) {
+ $ipent = $a_allowedips[$_GET['id']];
+ if ($ipent['dir'] == "from")
+ mwexec("/sbin/ipfw table 1 delete " . $ipent['ip']);
+ else
+ mwexec("/sbin/ipfw table 2 delete " . $ipent['ip']);
+
unset($a_allowedips[$_GET['id']]);
write_config();
- mark_subsystem_dirty('allowedips');
header("Location: services_captiveportal_ip.php");
exit;
}
@@ -76,9 +66,6 @@ include("head.inc");
<body link="#0000CC" vlink="#0000CC" alink="#0000CC">
<form action="services_captiveportal_ip.php" method="post">
<?php if ($savemsg) print_info_box($savemsg); ?>
-<?php if (is_subsystem_dirty('allowedips')): ?>
-<?php print_info_box_np("The captive portal IP address configuration has been changed.<br>You must apply the changes in order for them to take effect.");?><br>
-<?php endif; ?>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr><td class="tabnavtbl">
<?php
OpenPOWER on IntegriCloud