Ticket #944. Do not use the interface_bring_down fucntion here since it is meant for assigned interfaces. Directly destroy previous vlan interface if parent changes.

1 files changed, 5 insertions, 5 deletions

diff --git a/usr/local/www/interfaces_vlan_edit.php b/usr/local/www/interfaces_vlan_edit.php
index f548386..ea43508 100755
--- a/usr/local/www/interfaces_vlan_edit.php
+++ b/usr/local/www/interfaces_vlan_edit.php
@@ -96,17 +96,17 @@ if ($_POST) {
 	}
 
 	if (!$input_errors) {
+		if (isset($id) && $a_vlans[$id]) {
+			if ($a_vlans[$id]['if'] != $_POST['if'])
+				// Destroy previous vlan
+				pfSense_interface_destroy($a_vlans[$id]['if']);
+		}
 		$vlan = array();
 		$vlan['if'] = $_POST['if'];
 		$vlan['tag'] = $_POST['tag'];
 		$vlan['descr'] = $_POST['descr'];
 		$vlan['vlanif'] = "{$_POST['if']}_vlan{$_POST['tag']}";
 
-		if (isset($id) && $a_vlans[$id]) {
-			if ($a_vlans[$id]['if'] != $_POST['if'])
-				// Destroy previous vlan
-				interface_bring_down($a_vlans[$id]['if'], true);
-		}
 		$vlan['vlanif'] = interface_vlan_configure($vlan);
                 if ($vlan['vlanif'] == "" || !stristr($vlan['vlanif'], "vlan"))
                         $input_errors[] = gettext("Error occured creating interface, please retry.");