diff options
| author | Renato Botelho <garga@FreeBSD.org> | 2014-02-04 12:33:29 -0200 |
|---|---|---|
| committer | Renato Botelho <garga@FreeBSD.org> | 2014-02-04 12:34:42 -0200 |
| commit | d31ca3363dcb7b243f71118744123a5ba71665cb (patch) | |
| tree | d9478b15b7a4316a10b7a9b5d4a415c272285a1c /usr/local/www/diag_smart.php | |
| parent | 39ed87e54d14af2603cc66e65ac5e13a9c9843b1 (diff) | |
| download | pfsense-d31ca3363dcb7b243f71118744123a5ba71665cb.zip pfsense-d31ca3363dcb7b243f71118744123a5ba71665cb.tar.gz | |
Add escapeshellarg() calls on exec parameters. While I'm here, replace some exec() calls by php functions like symlink, copy, unlink, mkdir
Diffstat (limited to 'usr/local/www/diag_smart.php')
| -rw-r--r-- | usr/local/www/diag_smart.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/usr/local/www/diag_smart.php b/usr/local/www/diag_smart.php index d7e8072..73f3405 100644 --- a/usr/local/www/diag_smart.php +++ b/usr/local/www/diag_smart.php @@ -85,7 +85,7 @@ function update_email($email) if(!empty($email)) { // Put it in the smartd.conf file - shell_exec("/usr/bin/sed -i old 's/^DEVICESCAN.*/DEVICESCAN -H -m " . $email . "/' /usr/local/etc/smartd.conf"); + shell_exec("/usr/bin/sed -i old 's/^DEVICESCAN.*/DEVICESCAN -H -m " . escapeshellarg($email) . "/' /usr/local/etc/smartd.conf"); } // Nope else @@ -98,7 +98,7 @@ function update_email($email) function smartmonctl($action) { global $start_script; - shell_exec($start_script . $action); + shell_exec($start_script . escapeshellarg($action)); } // What page, aka. action is being wanted |
