Tidy up "diag_confbak.php" XHTML

Move VALIGN to STYLE statement
Add the colour WHITE other BGCOLOR will display error
Add SUMMARY to TABLES
Close INPUT and IMG tags
Move NOWRAP into CLASS statement
Remove duplicate closing FORM tag

1 files changed, 20 insertions, 20 deletions

diff --git a/usr/local/www/diag_confbak.php b/usr/local/www/diag_confbak.php
index 3cfae37..dbe2bf7 100644
--- a/usr/local/www/diag_confbak.php
+++ b/usr/local/www/diag_confbak.php
@@ -118,7 +118,7 @@ include("head.inc");
 			print_info_box($savemsg);
 	?>
 	<?php if ($diff) { ?>
-	<table align="center" valign="middle" width="100%" border="0" cellspacing="0" style="padding-top: 4px; padding-bottom: 4px;">
+	<table align="center" width="100%" border="0" cellspacing="0" style="padding-top: 4px; padding-bottom: 4px; vertical-align:middle;" summary="diag confbak">
 		<tr><td><?=gettext("Configuration diff from");?> <?php echo date(gettext("n/j/y H:i:s"), $oldtime); ?> <?=gettext("to");?> <?php echo date(gettext("n/j/y H:i:s"), $newtime); ?></td></tr>
 		<?php foreach ($diff as $line) {
 			switch (substr($line, 0, 1)) {
@@ -132,7 +132,7 @@ include("head.inc");
 					$color = "#a0a0a0";
 					break;
 				default:
-					$color = "";
+					$color = "#ffffff";
 			}
 			?>
 		<tr>
@@ -142,7 +142,7 @@ include("head.inc");
 	</table>
 	<br />
 	<?php } ?>
-	<table width="100%" border="0" cellpadding="0" cellspacing="0">
+	<table width="100%" border="0" cellpadding="0" cellspacing="0" summary="stats">
 		<tr>
 			<td>
 			<?php
@@ -157,17 +157,17 @@ include("head.inc");
 			<td>
 				<div id="mainarea">
 					<form action="diag_confbak.php" method="post">
-					<table class="tabcont" align="center" width="100%" border="0" cellpadding="6" cellspacing="0">
+					<table class="tabcont" align="center" width="100%" border="0" cellpadding="6" cellspacing="0" summary="tabcont">
 						<tr>
 							<td width="10%">&nbsp;</td>
 							<td width="15%" valign="top"><?=gettext("Backup Count");?></td>
-							<td width="10%" align="top">
+							<td width="10%">
 							<input name="backupcount" type="text" class="formfld unknown" size="5" value="<?=htmlspecialchars($config['system']['backupcount']);?>"/>
 							</td>
 							<td width="60%">
 							<?= gettext("Enter the number of older configurations to keep in the local backup cache. By default this is 30 for a full install or 5 on NanoBSD."); ?>
 							</td>
-							<td width= "5%"><input name="save" type="submit" class="formbtn" value="<?=gettext("Save"); ?>"></td>
+							<td width= "5%"><input name="save" type="submit" class="formbtn" value="<?=gettext("Save"); ?>" /></td>
 						</tr>
 						<tr>
 							<td class="vncell">&nbsp;</td>
@@ -178,7 +178,7 @@ include("head.inc");
 					</table>
 					</form>
 					<form action="diag_confbak.php" method="get">
-					<table class="tabcont" align="center" width="100%" border="0" cellpadding="6" cellspacing="0">
+					<table class="tabcont" align="center" width="100%" border="0" cellpadding="6" cellspacing="0" summary="difference">
 						<?php if (is_array($confvers)): ?>
 						<tr>
 							<td colspan="7" class="list">
@@ -187,7 +187,7 @@ include("head.inc");
 							</td>
 						</tr>
 						<tr>
-							<td width="5%" colspan="2" valign="middle" align="center" class="list" nowrap><input type="submit" name="diff" value="<?=gettext("Diff"); ?>"></td>
+							<td width="5%" colspan="2" valign="middle" align="center" class="list nowrap"><input type="submit" name="diff" value="<?=gettext("Diff"); ?>" /></td>
 							<td width="20%" class="listhdrr"><?=gettext("Date");?></td>
 							<td width="5%" class="listhdrr"><?=gettext("Version");?></td>
 							<td width="5%" class="listhdrr"><?=gettext("Size");?></td>
@@ -195,15 +195,15 @@ include("head.inc");
 							<td width="5%" class="list">&nbsp;</td>
 						</tr>
 						<tr valign="top">
-							<td valign="middle" class="list" nowrap></td>
+							<td valign="middle" class="list nowrap"></td>
 							<td class="list">
-								<input type="radio" name="newtime" value="current">
+								<input type="radio" name="newtime" value="current" />
 							</td>
 							<td class="listlr"> <?= date(gettext("n/j/y H:i:s"), $config['revision']['time']) ?></td>
 							<td class="listr"> <?= $config['version'] ?></td>
 							<td class="listr"> <?= format_bytes(filesize("/conf/config.xml")) ?></td>
 							<td class="listr"> <?= $config['revision']['description'] ?></td>
-							<td valign="middle" class="list" nowrap><b><?=gettext("Current");?></b></td>
+							<td valign="middle" class="list nowrap"><b><?=gettext("Current");?></b></td>
 						</tr>
 						<?php
 							$c = 0;
@@ -215,11 +215,11 @@ include("head.inc");
 						?>
 						<tr valign="top">
 							<td class="list">
-								<input type="radio" name="oldtime" value="<?php echo $version['time'];?>">
+								<input type="radio" name="oldtime" value="<?php echo $version['time'];?>" />
 							</td>
 							<td class="list">
 								<?php if ($c < (count($confvers) - 1)) { ?>
-								<input type="radio" name="newtime" value="<?php echo $version['time'];?>">
+								<input type="radio" name="newtime" value="<?php echo $version['time'];?>" />
 								<?php } else { ?>
 								&nbsp;
 								<?php }
@@ -229,21 +229,21 @@ include("head.inc");
 							<td class="listr"> <?= $version['version'] ?></td>
 							<td class="listr"> <?= format_bytes($version['filesize']) ?></td>
 							<td class="listr"> <?= $version['description'] ?></td>
-							<td valign="middle" class="list" nowrap>
-							<a href="diag_confbak.php?newver=<?=$version['time'];?>" onclick="return confirm('<?=gettext("Revert to this configuration?");?>'")>
-							<img src="/themes/<?= $g['theme']; ?>/images/icons/icon_plus.gif" width="17" height="17" border="0" alt="<?=gettext("Revert to this configuration");?>" title="<?=gettext("Revert to this configuration");?>">
+							<td valign="middle" class="list nowrap">
+							<a href="diag_confbak.php?newver=<?=$version['time'];?>" onclick="return confirm('<?=gettext("Revert to this configuration?");?>')">
+							<img src="/themes/<?= $g['theme']; ?>/images/icons/icon_plus.gif" width="17" height="17" border="0" alt="<?=gettext("Revert to this configuration");?>" title="<?=gettext("Revert to this configuration");?>" />
 								</a>
 							<a href="diag_confbak.php?rmver=<?=$version['time'];?>" onclick="return confirm('<?=gettext("Delete this configuration backup?");?>')">
-							<img src="/themes/<?= $g['theme']; ?>/images/icons/icon_x.gif" width="17" height="17" border="0" alt="<?=gettext("Remove this backup");?>" title="<?=gettext("Remove this backup");?>">
+							<img src="/themes/<?= $g['theme']; ?>/images/icons/icon_x.gif" width="17" height="17" border="0" alt="<?=gettext("Remove this backup");?>" title="<?=gettext("Remove this backup");?>" />
 								</a>
 								<a href="diag_confbak.php?getcfg=<?=$version['time'];?>">
-								<img src="/themes/<?= $g['theme']; ?>/images/icons/icon_down.gif" width="17" height="17" border="0" alt="<?=gettext("Download this backup");?>" title="<?=gettext("Download this backup");?>">
+								<img src="/themes/<?= $g['theme']; ?>/images/icons/icon_down.gif" width="17" height="17" border="0" alt="<?=gettext("Download this backup");?>" title="<?=gettext("Download this backup");?>" />
 								</a>
 							</td>
 						</tr>
 						<?php endforeach; ?>
 						<tr>
-							<td colspan="2"><input type="submit" name="diff" value="<?=gettext("Diff"); ?>"></td>
+							<td colspan="2"><input type="submit" name="diff" value="<?=gettext("Diff"); ?>" /></td>
 							<td colspan="5"></td>
 						</tr>
 						<?php else: ?>
@@ -259,7 +259,7 @@ include("head.inc");
 			</td>
 		</tr>
 	</table>
-</form>
+
 <?php include("fend.inc"); ?>
 </body>
 </html>