Leave an empty file for URL Table aliases that return an empty file, and include it in the ruleset regardless so it doesn't generate any filter errors. Ticket #6181

2 files changed, 7 insertions, 1 deletions

diff --git a/src/etc/inc/pfsense-utils.inc b/src/etc/inc/pfsense-utils.inc
index 7f7fa9b..5f38101 100644
--- a/src/etc/inc/pfsense-utils.inc
+++ b/src/etc/inc/pfsense-utils.inc
@@ -2421,6 +2421,8 @@ function process_alias_urltable($name, $type, $url, $freq, $forceupdate=false, $
 			}
 			if (is_array($parsed_contents)) {
 				file_put_contents($urltable_filename, implode("\n", $parsed_contents));
+			} else {
+				touch($urltable_filename);
 			}
 
 			/* If this backup is still there on a full install, but we aren't going to use ram disks, remove the archive since this is a transition. */
diff --git a/src/etc/inc/util.inc b/src/etc/inc/util.inc
index d41a79b..c83fd9c 100644
--- a/src/etc/inc/util.inc
+++ b/src/etc/inc/util.inc
@@ -1776,7 +1776,11 @@ function alias_expand_urltable($name) {
 	if (is_array($config['aliases']['alias'])) {
 		foreach ($config['aliases']['alias'] as $alias) {
 			if (preg_match("/urltable/i", $alias['type']) && ($alias['name'] == $name)) {
-				if (is_URL($alias["url"]) && file_exists($urltable_filename) && filesize($urltable_filename)) {
+				if (is_URL($alias["url"]) && file_exists($urltable_filename)) {
+					if (!filesize($urltable_filename)) {
+						// file exists, but is empty, try to sync
+						send_event("service sync alias {$name}");
+					}
 					return $urltable_filename;
 				} else {
 					send_event("service sync alias {$name}");