diff options
author | Steve Beaver <sbeaver@netgate.com> | 2017-02-10 11:12:20 -0500 |
---|---|---|
committer | Steve Beaver <sbeaver@netgate.com> | 2017-02-10 11:12:50 -0500 |
commit | c5ae2b4df3e4dec87757ae4f8e7e39931e11551f (patch) | |
tree | 23b24be13a716565915043d576df8ace4e3e6e3f /src | |
parent | ad1e294ce5a735b680aa9ef93f25906077c8812d (diff) | |
download | pfsense-c5ae2b4df3e4dec87757ae4f8e7e39931e11551f.zip pfsense-c5ae2b4df3e4dec87757ae4f8e7e39931e11551f.tar.gz |
GET/POST conversion interfaces_bridge*
Diffstat (limited to 'src')
-rw-r--r-- | src/usr/local/www/interfaces_bridge.php | 20 | ||||
-rw-r--r-- | src/usr/local/www/interfaces_bridge_edit.php | 9 |
2 files changed, 12 insertions, 17 deletions
diff --git a/src/usr/local/www/interfaces_bridge.php b/src/usr/local/www/interfaces_bridge.php index 359af1c..a817f6d 100644 --- a/src/usr/local/www/interfaces_bridge.php +++ b/src/usr/local/www/interfaces_bridge.php @@ -48,22 +48,22 @@ function bridge_inuse($num) { return false; } -if ($_GET['act'] == "del") { - if (!isset($_GET['id'])) { +if ($_POST['act'] == "del") { + if (!isset($_POST['id'])) { $input_errors[] = gettext("Wrong parameters supplied"); - } else if (empty($a_bridges[$_GET['id']])) { + } else if (empty($a_bridges[$_POST['id']])) { $input_errors[] = gettext("Wrong index supplied"); /* check if still in use */ - } else if (bridge_inuse($_GET['id'])) { + } else if (bridge_inuse($_POST['id'])) { $input_errors[] = gettext("This bridge cannot be deleted because it is assigned as an interface."); } else { - if (!does_interface_exist($a_bridges[$_GET['id']]['bridgeif'])) { + if (!does_interface_exist($a_bridges[$_POST['id']]['bridgeif'])) { log_error("Bridge interface does not exist, skipping ifconfig destroy."); } else { - pfSense_interface_destroy($a_bridges[$_GET['id']]['bridgeif']); + pfSense_interface_destroy($a_bridges[$_POST['id']]['bridgeif']); } - unset($a_bridges[$_GET['id']]); + unset($a_bridges[$_POST['id']]); write_config(); @@ -136,8 +136,8 @@ foreach ($a_bridges as $bridge) { <?=htmlspecialchars($bridge['descr'])?> </td> <td> - <a class="fa fa-pencil" title="<?=gettext('Edit interface bridge')?>" href="interfaces_bridge_edit.php?id=<?=$i?>"></a> - <a class="fa fa-trash" title="<?=gettext('Delete interface bridge')?>" href="interfaces_bridge.php?act=del&id=<?=$i?>"></a> + <a class="fa fa-pencil" title="<?=gettext('Edit interface bridge')?>" href="interfaces_bridge_edit.php?id=<?=$i?>" usepost></a> + <a class="fa fa-trash" title="<?=gettext('Delete interface bridge')?>" href="interfaces_bridge.php?act=del&id=<?=$i?>" usepost></a> </td> </tr> <?php @@ -151,7 +151,7 @@ foreach ($a_bridges as $bridge) { </div> <nav class="action-buttons"> - <a href="interfaces_bridge_edit.php" class="btn btn-success btn-sm"> + <a href="interfaces_bridge_edit.php" class="btn btn-success btn-sm" usepost> <i class="fa fa-plus icon-embed-btn"></i> <?=gettext("Add")?> </a> diff --git a/src/usr/local/www/interfaces_bridge_edit.php b/src/usr/local/www/interfaces_bridge_edit.php index eb3da42..5a1c23f 100644 --- a/src/usr/local/www/interfaces_bridge_edit.php +++ b/src/usr/local/www/interfaces_bridge_edit.php @@ -65,12 +65,7 @@ foreach ($ifacelist as $bif => $bdescr) { } } -if (is_numericint($_GET['id'])) { - $id = $_GET['id']; -} -if (isset($_POST['id']) && is_numericint($_POST['id'])) { - $id = $_POST['id']; -} +$id = $_POST['id']; if (isset($id) && $a_bridges[$id]) { $pconfig['enablestp'] = isset($a_bridges[$id]['enablestp']); @@ -138,7 +133,7 @@ if (isset($id) && $a_bridges[$id]) { } } -if ($_POST) { +if ($_POST['save']) { unset($input_errors); $pconfig = $_POST; |