diff options
| author | Phil Davis <phil.davis@inf.org> | 2017-01-25 12:19:23 +0545 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-01-25 12:19:23 +0545 |
| commit | 0ee22f364ca62b8305ff36447954dacdbc3c3cce (patch) | |
| tree | 69d543810355d11096e8614b97e07bdaf7945354 /src | |
| parent | 47f2a4b9eb22ea6f1f6baad83e3786ecb53c5394 (diff) | |
| download | pfsense-0ee22f364ca62b8305ff36447954dacdbc3c3cce.zip pfsense-0ee22f364ca62b8305ff36447954dacdbc3c3cce.tar.gz | |
Captive Portal auth method is required
When creating a new Captive Portal Zone the user can fail to select any of the Authorization Method radio buttons. No default radio button is selected - that is probably good, as the user has to think and click to decide which authorization method they will use.
But the form validation should check that some valid value is POSTed when the CP is enabled.
Diffstat (limited to 'src')
| -rw-r--r-- | src/usr/local/www/services_captiveportal.php | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/usr/local/www/services_captiveportal.php b/src/usr/local/www/services_captiveportal.php index 912e3d0..819f51a 100644 --- a/src/usr/local/www/services_captiveportal.php +++ b/src/usr/local/www/services_captiveportal.php @@ -212,8 +212,8 @@ if ($_POST) { /* input validation */ if ($_POST['enable']) { - $reqdfields = explode(" ", "zone cinterface"); - $reqdfieldsn = array(gettext("Zone name"), gettext("Interface")); + $reqdfields = explode(" ", "zone cinterface auth_method"); + $reqdfieldsn = array(gettext("Zone name"), gettext("Interface"), gettext("Authentication method")); if (isset($_POST['auth_method']) && $_POST['auth_method'] == "radius") { $reqdfields[] = "radius_protocol"; @@ -240,6 +240,10 @@ if ($_POST) { } } + if ($_POST['auth_method'] && !in_array($_POST['auth_method'], array('none', 'local', 'radius'))) { + $input_errors[] = sprintf(gettext("Authentication method %s is invalid."), $_POST['auth_method']); + } + if ($_POST['httpslogin_enable']) { if (!$_POST['certref']) { $input_errors[] = gettext("Certificate must be specified for HTTPS login."); |
