summaryrefslogtreecommitdiffstats
path: root/src/usr
diff options
context:
space:
mode:
authorPhil Davis <phil.davis@inf.org>2016-06-15 10:45:16 +0930
committerGitHub <noreply@github.com>2016-06-15 10:45:16 +0930
commitfa20dac1b58488713d88b44cafc760a83d79cb66 (patch)
tree41ba7c38a727278d4b09cdc781f6b2641cf6030e /src/usr
parentf68dc9f497b7002ff5a7ab7f8aa9abcb8049b6d6 (diff)
downloadpfsense-fa20dac1b58488713d88b44cafc760a83d79cb66.zip
pfsense-fa20dac1b58488713d88b44cafc760a83d79cb66.tar.gz
Fix #6482 OpenVPN Redirect Gateway Option Causes GUI Issue
This fixes the GUI inconsistency reported in the referenced bug. On edit of an OpenVPN server that has tun mode, not shared key, and the gwredir checkbox checked, the local_network fields are shown, but actually they should be hidden (because that is what happens on first data entry when gwredir is checked). At least this makes the GUI consistent. Then the other issues mentioned in Redmine feature 6483 can be addressed separately.
Diffstat (limited to 'src/usr')
-rw-r--r--src/usr/local/www/vpn_openvpn_server.php6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/usr/local/www/vpn_openvpn_server.php b/src/usr/local/www/vpn_openvpn_server.php
index 12a883c..6d44b5d 100644
--- a/src/usr/local/www/vpn_openvpn_server.php
+++ b/src/usr/local/www/vpn_openvpn_server.php
@@ -1497,8 +1497,10 @@ events.push(function() {
hideInput('local_networkv6', true);
hideInput('topology', true);
} else {
- hideInput('local_network', false);
- hideInput('local_networkv6', false);
+ // For tunnel mode that is not shared key,
+ // the display status of local network fields depends on
+ // the state of the gwredir checkbox.
+ gwredir_change();
hideInput('topology', false);
}
break;
OpenPOWER on IntegriCloud