Fixed #7171

Moved setHelpText() to helpers file

3 files changed, 5 insertions, 8 deletions

diff --git a/src/usr/local/www/firewall_rules_edit.php b/src/usr/local/www/firewall_rules_edit.php
index 6c613d1..159d066 100644
--- a/src/usr/local/www/firewall_rules_edit.php
+++ b/src/usr/local/www/firewall_rules_edit.php
@@ -2055,10 +2055,6 @@ events.push(function() {
 	});
 
 	// Change help text based on the selector value
-	function setHelpText(id, text) {
-		$('#' + id).parent().parent('div').find('span').find('span').html(text);
-	}
-
 	function setOptText(target, val) {
 		var dispstr = '<span class="text-success">';
 
diff --git a/src/usr/local/www/js/pfSenseHelpers.js b/src/usr/local/www/js/pfSenseHelpers.js
index 49c9415..f17e422 100644
--- a/src/usr/local/www/js/pfSenseHelpers.js
+++ b/src/usr/local/www/js/pfSenseHelpers.js
@@ -120,6 +120,11 @@ function hideMask(name, hide) {
 	}
 }
 
+// Set the help text for a given input
+function setHelpText(id, text) {
+	$('#' + id).parent().parent('div').find('span:nth-child(2)').html(text);
+}
+
 // Toggle table row checkboxes and background colors on the pages that use sortable tables:
 //	/usr/local/www/firewall_nat.php
 //	/usr/local/www/firewall_nat_1to1.php
diff --git a/src/usr/local/www/system_advanced_firewall.php b/src/usr/local/www/system_advanced_firewall.php
index 3fc3b10..7779133 100644
--- a/src/usr/local/www/system_advanced_firewall.php
+++ b/src/usr/local/www/system_advanced_firewall.php
@@ -699,10 +699,6 @@ print $form;
 //<![CDATA[
 events.push(function() {
 	// Change help text based on the selector value
-	function setHelpText(id, text) {
-		$('#' + id).parent().parent('div').find('span').html(text);
-	}
-
 	function setOptText(val) {
 		var htext = '<span class="text-success">';