diff options
| author | Steve Beaver <sbeaver@netgate.com> | 2017-02-13 10:47:47 -0500 |
|---|---|---|
| committer | Steve Beaver <sbeaver@netgate.com> | 2017-02-13 10:48:25 -0500 |
| commit | 4611e283323f0eaf44bc4ded4ad4f7cf9d8cdbe1 (patch) | |
| tree | 44a60f536cefad3d50cefccf780c98094e217d1a /src/usr/local/www/system_gateway_groups.php | |
| parent | ac4fe723a521e35a29fb55075cdfdb2230d74aa2 (diff) | |
| download | pfsense-4611e283323f0eaf44bc4ded4ad4f7cf9d8cdbe1.zip pfsense-4611e283323f0eaf44bc4ded4ad4f7cf9d8cdbe1.tar.gz | |
Revisions to GET/POST conversion limiting POSTs to save, apply, and delete functions
Diffstat (limited to 'src/usr/local/www/system_gateway_groups.php')
| -rw-r--r-- | src/usr/local/www/system_gateway_groups.php | 41 |
1 files changed, 20 insertions, 21 deletions
diff --git a/src/usr/local/www/system_gateway_groups.php b/src/usr/local/www/system_gateway_groups.php index 3a8f447..d91626c 100644 --- a/src/usr/local/www/system_gateway_groups.php +++ b/src/usr/local/www/system_gateway_groups.php @@ -41,29 +41,28 @@ $a_gateway_groups = &$config['gateways']['gateway_group']; $a_gateways = &$config['gateways']['gateway_item']; $changedesc = gettext("Gateway Groups") . ": "; -if ($_POST) { - $pconfig = $_POST; - if ($_POST['apply']) { +$pconfig = $_REQUEST; - $retval = 0; +if ($_POST['apply']) { - $retval |= system_routing_configure(); - send_multiple_events(array("service reload dyndnsall", "service reload ipsecdns", "filter reload")); + $retval = 0; - /* reconfigure our gateway monitor */ - setup_gateways_monitor(); + $retval |= system_routing_configure(); + send_multiple_events(array("service reload dyndnsall", "service reload ipsecdns", "filter reload")); - if ($retval == 0) { - clear_subsystem_dirty('staticroutes'); - } + /* reconfigure our gateway monitor */ + setup_gateways_monitor(); - foreach ($a_gateway_groups as $gateway_group) { - $gw_subsystem = 'gwgroup.' . $gateway_group['name']; - if (is_subsystem_dirty($gw_subsystem)) { - openvpn_resync_gwgroup($gateway_group['name']); - clear_subsystem_dirty($gw_subsystem); - } + if ($retval == 0) { + clear_subsystem_dirty('staticroutes'); + } + + foreach ($a_gateway_groups as $gateway_group) { + $gw_subsystem = 'gwgroup.' . $gateway_group['name']; + if (is_subsystem_dirty($gw_subsystem)) { + openvpn_resync_gwgroup($gateway_group['name']); + clear_subsystem_dirty($gw_subsystem); } } } @@ -72,7 +71,7 @@ if ($_POST['act'] == "del") { if ($a_gateway_groups[$_POST['id']]) { $changedesc .= sprintf(gettext("removed gateway group %s"), $_POST['id']); foreach ($config['filter']['rule'] as $idx => $rule) { - if ($rule['gateway'] == $a_gateway_groups[$_POST['id']]['name']) { + if ($rule['gateway'] == $a_gateway_groups[$_REQUEST['id']]['name']) { unset($config['filter']['rule'][$idx]['gateway']); } } @@ -166,8 +165,8 @@ foreach ($a_gateway_groups as $gateway_group): <?=htmlspecialchars($gateway_group['descr'])?> </td> <td> - <a href="system_gateway_groups_edit.php?id=<?=$i?>" class="fa fa-pencil" title="<?=gettext('Edit gateway group')?>" usepost></a> - <a href="system_gateway_groups_edit.php?dup=<?=$i?>" class="fa fa-clone" title="<?=gettext('Copy gateway group')?>" usepost></a> + <a href="system_gateway_groups_edit.php?id=<?=$i?>" class="fa fa-pencil" title="<?=gettext('Edit gateway group')?>"></a> + <a href="system_gateway_groups_edit.php?dup=<?=$i?>" class="fa fa-clone" title="<?=gettext('Copy gateway group')?>"></a> <a href="system_gateway_groups.php?act=del&id=<?=$i?>" class="fa fa-trash" title="<?=gettext('Delete gateway group')?>" usepost></a> </td> </tr> @@ -182,7 +181,7 @@ endforeach; </div> <nav class="action-buttons"> - <a href="system_gateway_groups_edit.php" class="btn btn-success btn-sm" usepost> + <a href="system_gateway_groups_edit.php" class="btn btn-success btn-sm"> <i class="fa fa-plus icon-embed-btn"></i> <?=gettext('Add')?> </a> |
