summaryrefslogtreecommitdiffstats
path: root/src/usr/local/www/firewall_rules_edit.php
diff options
context:
space:
mode:
authorstilez <stilez@users.noreply.github.com>2016-12-29 08:22:06 +0000
committerGitHub <noreply@github.com>2016-12-29 08:22:06 +0000
commite9b3d2c3bfc3e91ac59901ca28d0620f7bb7b50f (patch)
treed728ab43b3d663500f9e8dd1dd36272d534917f3 /src/usr/local/www/firewall_rules_edit.php
parentc7fd8cd011b5c6dcd89173d40558b1708328e3ab (diff)
downloadpfsense-e9b3d2c3bfc3e91ac59901ca28d0620f7bb7b50f.zip
pfsense-e9b3d2c3bfc3e91ac59901ca28d0620f7bb7b50f.tar.gz
"Any" moved to top of list in new blank rules
@jim-p wanted this split out from PR 3159 as it wasn't related to that PR. Puts "any" at the logical place people look for it (top of list not 2/3 down it at random) while ensuring that for new rules default is tcp and extra ports etc fields are visible.
Diffstat (limited to 'src/usr/local/www/firewall_rules_edit.php')
-rw-r--r--src/usr/local/www/firewall_rules_edit.php3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/usr/local/www/firewall_rules_edit.php b/src/usr/local/www/firewall_rules_edit.php
index 5211255..7c0c12c 100644
--- a/src/usr/local/www/firewall_rules_edit.php
+++ b/src/usr/local/www/firewall_rules_edit.php
@@ -275,6 +275,7 @@ if (isset($id) && $a_filter[$id]) {
$pconfig['interface'] = $_GET['if'];
}
$pconfig['type'] = "pass";
+ $pconfig['proto'] = "tcp"; // for new blank rules, default=tcp, also ensures ports fields are visible
$pconfig['src'] = "any";
$pconfig['dst'] = "any";
}
@@ -1216,6 +1217,7 @@ $section->addInput(new Form_Select(
'Protocol',
$pconfig['proto'],
array(
+ 'any' => gettext('any'),
'tcp' => 'TCP',
'udp' => 'UDP',
'tcp/udp' => 'TCP/UDP',
@@ -1228,7 +1230,6 @@ $section->addInput(new Form_Select(
'pim' => 'PIM',
'ospf' => 'OSPF',
'sctp' => 'SCTP',
- 'any' => gettext('any'),
'carp' => 'CARP',
'pfsync' => 'PFSYNC',
)
OpenPOWER on IntegriCloud