diff options
author | jim-p <jimp@pfsense.org> | 2015-11-11 10:17:40 -0500 |
---|---|---|
committer | jim-p <jimp@pfsense.org> | 2015-11-11 10:17:40 -0500 |
commit | ed69a49666fa5f7e9fe1366d9f176ffba15536f1 (patch) | |
tree | 3b0ac14516b52048ebfcfe6aeb7ebf96ef9c0ef6 /src/usr/local/www/diag_ping.php | |
parent | 9eb8cafaa7b720810a4c158061114e5f7951fefb (diff) | |
download | pfsense-ed69a49666fa5f7e9fe1366d9f176ffba15536f1.zip pfsense-ed69a49666fa5f7e9fe1366d9f176ffba15536f1.tar.gz |
For Diag > Ping and Diag > Traceroute, only perform the action on POST, not by following a link/GET. Fixes #5400
Diffstat (limited to 'src/usr/local/www/diag_ping.php')
-rw-r--r-- | src/usr/local/www/diag_ping.php | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/src/usr/local/www/diag_ping.php b/src/usr/local/www/diag_ping.php index 11a596f..afaf0fe 100644 --- a/src/usr/local/www/diag_ping.php +++ b/src/usr/local/www/diag_ping.php @@ -75,6 +75,9 @@ require_once("guiconfig.inc"); define('MAX_COUNT', 10); define('DEFAULT_COUNT', 3); +$do_ping = false; +$host = ''; +$count = DEFAULT_COUNT; function create_sourceaddresslist() { $sourceips = get_possible_traffic_source_addresses(true); @@ -111,7 +114,9 @@ if ($_POST || $_REQUEST['host']) { } if (!$input_errors) { - $do_ping = true; + if ($_POST) { + $do_ping = true; + } if(isset($_REQUEST['sourceip'])) { $sourceip = $_REQUEST['sourceip']; } @@ -122,12 +127,6 @@ if ($_POST || $_REQUEST['host']) { } } -if (!isset($do_ping)) { - $do_ping = false; - $host = ''; - $count = DEFAULT_COUNT; -} - if ($do_ping) { ?> <script type="text/javascript"> |