diff options
| author | Phil Davis <phil.davis@inf.org> | 2014-12-12 21:04:46 +0545 |
|---|---|---|
| committer | Phil Davis <phil.davis@inf.org> | 2014-12-12 21:04:46 +0545 |
| commit | 87657b952897932518033d7c97c05f314cb14a06 (patch) | |
| tree | b96b15beb0e0ee44083b75c97c44ee0275592481 /etc/rc.initial.setlanip | |
| parent | c45c6ccd8bf05fe953677482c9cf3582f72f252a (diff) | |
| download | pfsense-87657b952897932518033d7c97c05f314cb14a06.zip pfsense-87657b952897932518033d7c97c05f314cb14a06.tar.gz | |
rc.initial.setlanip fix validation of CIDR within range
Currently this allows the user to input any number for the CIDR. I happened to try 44 for an IPv4 CIDR when playing.
This fixes that little bug - I think it is good to commit that first/separately so it can be identified apart from the other (y/n) checking/handling I am working on. Better to have separate commits for distinct bugs.
Diffstat (limited to 'etc/rc.initial.setlanip')
| -rwxr-xr-x | etc/rc.initial.setlanip | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/etc/rc.initial.setlanip b/etc/rc.initial.setlanip index f49cac2..430270d 100755 --- a/etc/rc.initial.setlanip +++ b/etc/rc.initial.setlanip @@ -284,7 +284,7 @@ function console_configure_ip_address($version) { echo "\n" . sprintf(gettext("Enter the new %s %s subnet bit count:"), $upperifname, $label_IPvX) . "\n> "; $intbits = chop(fgets($fp)); - $intbits_ok = is_numeric($intbits) && (($intbits >= 1) || ($intbits <= $maxbits)); + $intbits_ok = is_numeric($intbits) && (($intbits >= 1) && ($intbits <= $maxbits)); $restart_dhcpd = true; if ($version === 4 && $intbits < $maxbits) { |
