summaryrefslogtreecommitdiffstats
path: root/etc/inc
diff options
context:
space:
mode:
authorErmal <eri@pfsense.org>2010-10-25 12:28:45 +0000
committerErmal <eri@pfsense.org>2010-10-25 12:28:45 +0000
commit52e5285f7ee2738a51280e9350909ed15a30c227 (patch)
treec759403becd68723961f539717e786e0d8c38b52 /etc/inc
parent24b2aa62beafe22517dc34421b78001477703db7 (diff)
downloadpfsense-52e5285f7ee2738a51280e9350909ed15a30c227.zip
pfsense-52e5285f7ee2738a51280e9350909ed15a30c227.tar.gz
Make this more strict checking.
Diffstat (limited to 'etc/inc')
-rw-r--r--etc/inc/dyndns.class2
-rw-r--r--etc/inc/services.inc3
2 files changed, 2 insertions, 3 deletions
diff --git a/etc/inc/dyndns.class b/etc/inc/dyndns.class
index a5799d9..a07a793 100644
--- a/etc/inc/dyndns.class
+++ b/etc/inc/dyndns.class
@@ -124,7 +124,7 @@
$this->_ifIP = get_interface_ip($dnsIf);
// Ensure that we where able to lookup the IP
- if(!$this->_ifIP) {
+ if(!is_ipaddr($this->_ifIP)) {
log_error("There was an error trying to determine the IP for interface - {$dnsIf}({$this->_if}). Probably interface has no ip or is down. Dyndns update not possible for {$dnsService}.");
return;
}
diff --git a/etc/inc/services.inc b/etc/inc/services.inc
index 34f35e3..3035b8e 100644
--- a/etc/inc/services.inc
+++ b/etc/inc/services.inc
@@ -604,7 +604,6 @@ function services_dyndns_configure_client($conf) {
$dnsWilcard = $conf['wildcard'],
$dnsMX = $conf['mx'],
$dnsIf = "{$conf['interface']}");
-
}
function services_dyndns_configure($int = "") {
@@ -1371,4 +1370,4 @@ function install_cron_job($command, $active=false, $minute="0", $hour="*", $mont
configure_cron();
}
-?> \ No newline at end of file
+?>
OpenPOWER on IntegriCloud