diff options
| author | Renato Botelho <garga@FreeBSD.org> | 2014-06-06 11:48:15 -0300 |
|---|---|---|
| committer | Renato Botelho <garga@FreeBSD.org> | 2014-06-06 11:48:15 -0300 |
| commit | 2f9951fe0e401ed231d61b8c3ad75531a6dbb797 (patch) | |
| tree | 35636bfeca764404c8331acd9b543d873ab85023 /etc/inc/service-utils.inc | |
| parent | 1c52509cabc014ca55e07548338b3990bfc2ace9 (diff) | |
| download | pfsense-2f9951fe0e401ed231d61b8c3ad75531a6dbb797.zip pfsense-2f9951fe0e401ed231d61b8c3ad75531a6dbb797.tar.gz | |
Add some protection to parameters that come through _GET
Diffstat (limited to 'etc/inc/service-utils.inc')
| -rw-r--r-- | etc/inc/service-utils.inc | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/etc/inc/service-utils.inc b/etc/inc/service-utils.inc index 7c05176..362af4d 100644 --- a/etc/inc/service-utils.inc +++ b/etc/inc/service-utils.inc @@ -515,7 +515,7 @@ function service_control_start($name, $extras) { services_radvd_configure(); break; case 'captiveportal': - $zone = $extras['zone']; + $zone = htmlspecialchars($extras['zone']); captiveportal_init_webgui_zonename($zone); break; case 'ntpd': @@ -553,9 +553,9 @@ function service_control_start($name, $extras) { send_event("service restart sshd"); break; case 'openvpn': - $vpnmode = isset($extras['vpnmode']) ? $extras['vpnmode'] : $extras['mode']; + $vpnmode = isset($extras['vpnmode']) ? htmlspecialchars($extras['vpnmode']) : htmlspecialchars($extras['mode']); if (($vpnmode == "server") || ($vpnmode == "client")) { - $id = isset($extras['vpnid']) ? $extras['vpnid'] : $extras['id']; + $id = isset($extras['vpnid']) ? htmlspecialchars($extras['vpnid']) : htmlspecialchars($extras['id']); $configfile = "{$g['varetc_path']}/openvpn/{$vpnmode}{$id}.conf"; if (file_exists($configfile)) openvpn_restart_by_vpnid($vpnmode, $id); @@ -577,7 +577,7 @@ function service_control_stop($name, $extras) { killbypid("{$g['varrun_path']}/radvd.pid"); break; case 'captiveportal': - $zone = $extras['zone']; + $zone = htmlspecialchars($extras['zone']); killbypid("{$g['varrun_path']}/lighty-{$zone}-CaptivePortal.pid"); killbypid("{$g['varrun_path']}/lighty-{$zone}-CaptivePortal-SSL.pid"); break; @@ -624,9 +624,9 @@ function service_control_stop($name, $extras) { exec("/usr/local/sbin/ipsec stop"); break; case 'openvpn': - $vpnmode = $extras['vpnmode']; + $vpnmode = htmlspecialchars($extras['vpnmode']); if (($vpnmode == "server") or ($vpnmode == "client")) { - $id = $extras['id']; + $id = htmlspecialchars($extras['id']); $pidfile = "{$g['varrun_path']}/openvpn_{$vpnmode}{$id}.pid"; killbypid($pidfile); } @@ -648,7 +648,7 @@ function service_control_restart($name, $extras) { services_radvd_configure(); break; case 'captiveportal': - $zone = $extras['zone']; + $zone = htmlspecialchars($extras['zone']); killbypid("{$g['varrun_path']}/lighty-{$zone}-CaptivePortal.pid"); killbypid("{$g['varrun_path']}/lighty-{$zone}-CaptivePortal-SSL.pid"); captiveportal_init_webgui_zonename($zone); @@ -692,9 +692,9 @@ function service_control_restart($name, $extras) { send_event("service restart sshd"); break; case 'openvpn': - $vpnmode = $extras['vpnmode']; + $vpnmode = htmlspecialchars($extras['vpnmode']); if ($vpnmode == "server" || $vpnmode == "client") { - $id = $extras['id']; + $id = htmlspecialchars($extras['id']); $configfile = "{$g['varetc_path']}/openvpn/{$vpnmode}{$id}.conf"; if (file_exists($configfile)) openvpn_restart_by_vpnid($vpnmode, $id); |
