diff options
author | Phil Davis <phil.davis@inf.org> | 2015-07-22 19:36:09 +0545 |
---|---|---|
committer | Phil Davis <phil.davis@inf.org> | 2015-07-22 19:36:09 +0545 |
commit | a607968ab4fbfc5fa3baf6ce6282065e22b81847 (patch) | |
tree | 5a7529bb3382dc94eab21982af9101e8f979af63 /etc/fbtab | |
parent | fcb477c057a23706dc84b0b27deb2f411226faa0 (diff) | |
download | pfsense-a607968ab4fbfc5fa3baf6ce6282065e22b81847.zip pfsense-a607968ab4fbfc5fa3baf6ce6282065e22b81847.tar.gz |
Handle IPsec Advanced Settings save before IPsec is enabled
If the Advanced Settings are saved before any other IPsec is set up then $config['ipsec'] can be just the empty string. As a result you can get:
a) If you select some debug settings then those are not saved. The code to save those settings was only executed when $config['ipsec'] was already an array. Actually the code already did the necessary "if isset() then unset()" stuuf. So I just took the the "if is_array()" away from the code block.
b) Some potential unset() can go wrong with errors like:
Fatal error: Cannot unset string offsets in /usr/local/www/vpn_ipsec_settings.php on line 168
This is corrected by adding more "if (isset())" checks.
Fixes Redmine #4865
Diffstat (limited to 'etc/fbtab')
0 files changed, 0 insertions, 0 deletions