diff options
author | stilez <stilez@users.noreply.github.com> | 2016-09-15 09:57:33 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-09-15 09:57:33 +0100 |
commit | cf1aaf9c5afcd34ed6d2bebc577fd527c42c80b4 (patch) | |
tree | 3cae9943a97bd713a03b919cdfd74b4bec5581d2 | |
parent | 7a4b11b6a495ddc747db5e44f5a62891ef86398c (diff) | |
download | pfsense-cf1aaf9c5afcd34ed6d2bebc577fd527c42c80b4.zip pfsense-cf1aaf9c5afcd34ed6d2bebc577fd527c42c80b4.tar.gz |
Enhance ICMP types in rules
See main PR for details
-rw-r--r-- | src/usr/local/www/firewall_rules.php | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/src/usr/local/www/firewall_rules.php b/src/usr/local/www/firewall_rules.php index f5d4d5d..92a5f1a 100644 --- a/src/usr/local/www/firewall_rules.php +++ b/src/usr/local/www/firewall_rules.php @@ -680,14 +680,13 @@ foreach ($a_filter as $filteri => $filterent): echo strtoupper($filterent['protocol']); if (strtoupper($filterent['protocol']) == "ICMP" && !empty($filterent['icmptype'])) { - echo ' <span style="cursor: help;" title="' . gettext('ICMP type') . ': ' . - ($filterent['ipprotocol'] == "inet6" ? $icmp6types[$filterent['icmptype']] : $icmptypes[$filterent['icmptype']]) . - '"><u>'; - echo $filterent['icmptype']; - echo '</u></span>'; + $t = array(); + foreach (explode(',', $filterent['icmptype']) as $type) { + $t[] = $icmptypes[$type]['descrip']; + } + echo sprintf(' <span style="cursor: help;" title="%s:%s%s"><u>%s</u></span>', gettext('ICMP subtypes'), chr(13), implode(', ', $t), $filterent['icmptype']); } - } else echo "*"; - + } else echo " *"; ?> </td> <td> |