diff options
author | Ermal Luçi <eri@pfsense.org> | 2009-11-30 06:43:44 +0000 |
---|---|---|
committer | Ermal Luçi <eri@pfsense.org> | 2009-11-30 06:43:44 +0000 |
commit | b6867d814bf8f47a4f1f6155e9f6caa1c9aaca0b (patch) | |
tree | af1ffc80032124862992491c235bddf485b93e56 | |
parent | 72cb5bafa3e000bdf19118ef28fa721c841294fd (diff) | |
download | pfsense-b6867d814bf8f47a4f1f6155e9f6caa1c9aaca0b.zip pfsense-b6867d814bf8f47a4f1f6155e9f6caa1c9aaca0b.tar.gz |
Ticket #146. Fix the autocompletion of ports aliases only for the ports and host/network aliases for the src/dst. Checking if a valid alias is entered end if it is a correct one for this box seems like to much overhead and work for this. (For firewall_nat_edit.php)
-rwxr-xr-x | usr/local/www/firewall_nat_edit.php | 25 | ||||
-rw-r--r-- | usr/local/www/javascript/firewall_nat_edit/firewall_nat_edit.js | 10 |
2 files changed, 17 insertions, 18 deletions
diff --git a/usr/local/www/firewall_nat_edit.php b/usr/local/www/firewall_nat_edit.php index bd2b773..f183f68 100755 --- a/usr/local/www/firewall_nat_edit.php +++ b/usr/local/www/firewall_nat_edit.php @@ -480,21 +480,28 @@ $addrisfirst = 0; $aliasesaddr = ""; if($config['aliases']['alias'] <> "") foreach($config['aliases']['alias'] as $alias_name) { - if(!stristr($alias_name['address'], ".")) { - if($isfirst == 1) $aliases .= ","; - $aliases .= "'" . $alias_name['name'] . "'"; - $isfirst = 1; - } else { - if($addrisfirst == 1) $aliasesaddr .= ","; - $aliasesaddr .= "'" . $alias_name['name'] . "'"; - $addrisfirst = 1; + switch ($alias_name['type']) { + case "port": + if($isfirst == 1) $portaliases .= ","; + $portaliases .= "'" . $alias_name['name'] . "'"; + $isfirst = 1; + break; + case "host": + case "network": + case "openvpn": + if($addrisfirst == 1) $aliasesaddr .= ","; + $aliasesaddr .= "'" . $alias_name['name'] . "'"; + $addrisfirst = 1; + break; + default: + break; } } ?> <script language="JavaScript"> <!-- var addressarray=new Array(<?php echo $aliasesaddr; ?>); - var customarray=new Array(<?php echo $aliases; ?>); + var customarray=new Array(<?php echo $portaliases; ?>); var oTextbox1 = new AutoSuggestControl(document.getElementById("localip"), new StateSuggestions(addressarray)); var oTextbox2 = new AutoSuggestControl(document.getElementById("beginport_cust"), new StateSuggestions(customarray)); diff --git a/usr/local/www/javascript/firewall_nat_edit/firewall_nat_edit.js b/usr/local/www/javascript/firewall_nat_edit/firewall_nat_edit.js index bce5e43..a2dff4c 100644 --- a/usr/local/www/javascript/firewall_nat_edit/firewall_nat_edit.js +++ b/usr/local/www/javascript/firewall_nat_edit/firewall_nat_edit.js @@ -90,12 +90,4 @@ function proto_change() { document.iform.localbeginport.disabled = 0; } } - -window.onload = function () { - var oTextbox1 = new AutoSuggestControl(document.getElementById("localip"), new StateSuggestions(addressarray)); - var oTextbox2 = new AutoSuggestControl(document.getElementById("beginport_cust"), new StateSuggestions(customarray)); - var oTextbox3 = new AutoSuggestControl(document.getElementById("endport_cust"), new StateSuggestions(customarray)); - var oTextbox4 = new AutoSuggestControl(document.getElementById("localbeginport_cust"), new StateSuggestions(customarray)); -} - -//-->
\ No newline at end of file +//--> |