summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNewEraCracker <neweracracker@gmail.com>2016-06-13 21:28:56 +0100
committerNewEraCracker <neweracracker@gmail.com>2016-06-13 21:28:56 +0100
commit9f4722022f0e8114741e8cf1a421520fded8be1f (patch)
tree82294c0a72688379025295f9e13fe1d747d1eecf
parentf68dc9f497b7002ff5a7ab7f8aa9abcb8049b6d6 (diff)
downloadpfsense-9f4722022f0e8114741e8cf1a421520fded8be1f.zip
pfsense-9f4722022f0e8114741e8cf1a421520fded8be1f.tar.gz
Fix PHP Warning about invalid argument supplied for foreach
If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions)
-rw-r--r--src/usr/local/www/system_groupmanager.php8
-rw-r--r--src/usr/local/www/system_usermanager.php8
2 files changed, 10 insertions, 6 deletions
diff --git a/src/usr/local/www/system_groupmanager.php b/src/usr/local/www/system_groupmanager.php
index 9510084..8e0d253 100644
--- a/src/usr/local/www/system_groupmanager.php
+++ b/src/usr/local/www/system_groupmanager.php
@@ -193,9 +193,11 @@ if (isset($_POST['save'])) {
}
/* Check the POSTed members to ensure they are valid and exist */
- foreach ($_POST['members'] as $newmember) {
- if (!is_numeric($newmember) || empty(getUserEntryByUID($newmember))) {
- $input_errors[] = gettext("One or more invalid group members was submitted.");
+ if(is_array($_POST['members'])) {
+ foreach ($_POST['members'] as $newmember) {
+ if (!is_numeric($newmember) || empty(getUserEntryByUID($newmember))) {
+ $input_errors[] = gettext("One or more invalid group members was submitted.");
+ }
}
}
diff --git a/src/usr/local/www/system_usermanager.php b/src/usr/local/www/system_usermanager.php
index dd462d6..3e87a25 100644
--- a/src/usr/local/www/system_usermanager.php
+++ b/src/usr/local/www/system_usermanager.php
@@ -214,9 +214,11 @@ if ($_POST['save']) {
}
/* Check the POSTed groups to ensure they are valid and exist */
- foreach ($_POST['groups'] as $newgroup) {
- if (empty(getGroupEntry($newgroup))) {
- $input_errors[] = gettext("One or more invalid groups was submitted.");
+ if(is_array($_POST['groups'])) {
+ foreach ($_POST['groups'] as $newgroup) {
+ if (empty(getGroupEntry($newgroup))) {
+ $input_errors[] = gettext("One or more invalid groups was submitted.");
+ }
}
}
OpenPOWER on IntegriCloud