diff options
author | Phil Davis <phil.davis@inf.org> | 2015-11-03 09:42:33 +0545 |
---|---|---|
committer | Phil Davis <phil.davis@inf.org> | 2015-11-03 09:42:33 +0545 |
commit | 873e2384c02835927c7ba7f27e63dc20cd7a0603 (patch) | |
tree | ff73aba662a1321e3e2cc6fbcc8545ada0b68a2a | |
parent | 87d4ff008132f0c201bcb193e81407956d320bb5 (diff) | |
download | pfsense-873e2384c02835927c7ba7f27e63dc20cd7a0603.zip pfsense-873e2384c02835927c7ba7f27e63dc20cd7a0603.tar.gz |
diag_logs_filter reduce duplicated icon code
Almost all the code in old lines 397 and 402 was the same. Make the logic a bit clearer about exactly what is the difference and hopefully reduce future code maintenance issues.
-rw-r--r-- | src/usr/local/www/diag_logs_filter.php | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/src/usr/local/www/diag_logs_filter.php b/src/usr/local/www/diag_logs_filter.php index 46ec120..00c38ba 100644 --- a/src/usr/local/www/diag_logs_filter.php +++ b/src/usr/local/www/diag_logs_filter.php @@ -393,16 +393,12 @@ if (!isset($config['syslog']['rawfilter'])) { <td> <?php if ($filterent['act'] == "block") { -?> - <i class="fa fa-times icon-danger icon-pointer" title="<?php echo $filterent['act'] .'/'. $filterent['tracker'];?>" onclick="javascript:getURL('diag_logs_filter.php?getrulenum=<?="{$filterent['rulenum']},{$filterent['tracker']},{$filterent['act']}"; ?>', outputrule);"></i> -<?php - } - else { -?> - <i class="fa fa-check icon-success icon-pointer" title="<?php echo $filterent['act'] .'/'. $filterent['tracker'];?>" onclick="javascript:getURL('diag_logs_filter.php?getrulenum=<?="{$filterent['rulenum']},{$filterent['tracker']},{$filterent['act']}"; ?>', outputrule);"></i> -<?php + $icon_act = "fa-times icon-danger"; + } else { + $icon_act = "fa-check icon-success"; } ?> + <i class="fa <?php echo $icon_act;?> icon-pointer" title="<?php echo $filterent['act'] .'/'. $filterent['tracker'];?>" onclick="javascript:getURL('diag_logs_filter.php?getrulenum=<?="{$filterent['rulenum']},{$filterent['tracker']},{$filterent['act']}"; ?>', outputrule);"></i> <?php if ($filterent['count']) echo $filterent['count']; |