diff options
| author | Chris Buechler <cmb@pfsense.org> | 2014-11-28 00:47:19 -0600 |
|---|---|---|
| committer | Chris Buechler <cmb@pfsense.org> | 2014-11-28 00:47:19 -0600 |
| commit | 823cabba18c7723e8db8cef614856ba77694c63d (patch) | |
| tree | 88b754b0a1086e733bdd946d0f10458c4ecb177b | |
| parent | f8f5ba1a1f9f15b3fc7e1fb3a806ed40daeb9023 (diff) | |
| download | pfsense-823cabba18c7723e8db8cef614856ba77694c63d.zip pfsense-823cabba18c7723e8db8cef614856ba77694c63d.tar.gz | |
Validate as integers, not just numeric, to prevent possible breakage.
| -rw-r--r-- | usr/local/www/system_advanced_admin.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/usr/local/www/system_advanced_admin.php b/usr/local/www/system_advanced_admin.php index 1148876..0ef818c 100644 --- a/usr/local/www/system_advanced_admin.php +++ b/usr/local/www/system_advanced_admin.php @@ -89,7 +89,7 @@ if ($_POST) { $input_errors[] = gettext("You must specify a valid webConfigurator port number"); if ($_POST['max_procs']) - if(!is_numeric($_POST['max_procs']) || ($_POST['max_procs'] < 1) || ($_POST['max_procs'] > 500)) + if(!is_numericint($_POST['max_procs']) || ($_POST['max_procs'] < 1) || ($_POST['max_procs'] > 500)) $input_errors[] = gettext("Max Processes must be a number 1 or greater"); if ($_POST['althostnames']) { @@ -150,7 +150,7 @@ if ($_POST) { else unset($config['system']['enableserial']); - if (is_numeric($_POST['serialspeed'])) + if (is_numericint($_POST['serialspeed'])) $config['system']['serialspeed'] = $_POST['serialspeed']; else unset($config['system']['serialspeed']); |
