summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRenato Botelho <renato@netgate.com>2017-01-04 18:53:20 -0200
committerRenato Botelho <renato@netgate.com>2017-01-04 18:53:20 -0200
commit414aa3596b25a2ecf98b63d1a774ba7d92b7e76c (patch)
tree25f043cda5e84d389a7c323df56d6d8bc1116d60
parentef70380433e2889f5a97ec7ddfa858baa18bb6ac (diff)
downloadpfsense-414aa3596b25a2ecf98b63d1a774ba7d92b7e76c.zip
pfsense-414aa3596b25a2ecf98b63d1a774ba7d92b7e76c.tar.gz
Remove direct calls to /sbin/ifconfig destroy by pfSense_interface_destroy()
-rwxr-xr-xsrc/usr/local/www/interfaces.php2
-rw-r--r--src/usr/local/www/interfaces_bridge.php2
-rw-r--r--src/usr/local/www/interfaces_gif.php2
-rw-r--r--src/usr/local/www/interfaces_gre.php2
-rw-r--r--src/usr/local/www/interfaces_lagg.php2
-rw-r--r--src/usr/local/www/interfaces_qinq.php2
-rw-r--r--src/usr/local/www/interfaces_wireless.php2
-rw-r--r--src/usr/local/www/interfaces_wireless_edit.php2
8 files changed, 8 insertions, 8 deletions
diff --git a/src/usr/local/www/interfaces.php b/src/usr/local/www/interfaces.php
index a63144d..fcb5763 100755
--- a/src/usr/local/www/interfaces.php
+++ b/src/usr/local/www/interfaces.php
@@ -1611,7 +1611,7 @@ function check_wireless_mode() {
if (!interface_wireless_clone("{$wlanif}_", $wancfg)) {
$input_errors[] = sprintf(gettext("Unable to change mode to %s. The maximum number of wireless clones supported in this mode may have been reached."), $wlan_modes[$wancfg['wireless']['mode']]);
} else {
- mwexec("/sbin/ifconfig " . escapeshellarg($wlanif) . "_ destroy");
+ pfSense_interface_destroy("{$wlanif}_");
}
$wancfg['wireless']['mode'] = $old_wireless_mode;
}
diff --git a/src/usr/local/www/interfaces_bridge.php b/src/usr/local/www/interfaces_bridge.php
index c9631d7..359af1c 100644
--- a/src/usr/local/www/interfaces_bridge.php
+++ b/src/usr/local/www/interfaces_bridge.php
@@ -60,7 +60,7 @@ if ($_GET['act'] == "del") {
if (!does_interface_exist($a_bridges[$_GET['id']]['bridgeif'])) {
log_error("Bridge interface does not exist, skipping ifconfig destroy.");
} else {
- mwexec("/sbin/ifconfig " . $a_bridges[$_GET['id']]['bridgeif'] . " destroy");
+ pfSense_interface_destroy($a_bridges[$_GET['id']]['bridgeif']);
}
unset($a_bridges[$_GET['id']]);
diff --git a/src/usr/local/www/interfaces_gif.php b/src/usr/local/www/interfaces_gif.php
index 1797092..b0581ec 100644
--- a/src/usr/local/www/interfaces_gif.php
+++ b/src/usr/local/www/interfaces_gif.php
@@ -56,7 +56,7 @@ if ($_GET['act'] == "del") {
} else if (gif_inuse($_GET['id'])) {
$input_errors[] = gettext("This gif TUNNEL cannot be deleted because it is still being used as an interface.");
} else {
- mwexec("/sbin/ifconfig " . $a_gifs[$_GET['id']]['gifif'] . " destroy");
+ pfSense_interface_destroy($a_gifs[$_GET['id']]['gifif']);
unset($a_gifs[$_GET['id']]);
write_config();
diff --git a/src/usr/local/www/interfaces_gre.php b/src/usr/local/www/interfaces_gre.php
index a69edd6..9f2d8c0 100644
--- a/src/usr/local/www/interfaces_gre.php
+++ b/src/usr/local/www/interfaces_gre.php
@@ -57,7 +57,7 @@ if ($_GET['act'] == "del") {
} else if (gre_inuse($_GET['id'])) {
$input_errors[] = gettext("This GRE tunnel cannot be deleted because it is still being used as an interface.");
} else {
- mwexec("/sbin/ifconfig " . $a_gres[$_GET['id']]['greif'] . " destroy");
+ pfSense_interface_destroy($a_gres[$_GET['id']]['greif']);
unset($a_gres[$_GET['id']]);
write_config();
diff --git a/src/usr/local/www/interfaces_lagg.php b/src/usr/local/www/interfaces_lagg.php
index c521558..23deb7d 100644
--- a/src/usr/local/www/interfaces_lagg.php
+++ b/src/usr/local/www/interfaces_lagg.php
@@ -63,7 +63,7 @@ if ($_GET['act'] == "del") {
} else if (lagg_inuse($_GET['id'])) {
$input_errors[] = gettext("This LAGG interface cannot be deleted because it is still being used.");
} else {
- mwexec_bg("/sbin/ifconfig " . $a_laggs[$_GET['id']]['laggif'] . " destroy");
+ pfSense_interface_destroy($a_laggs[$_GET['id']]['laggif']);
unset($a_laggs[$_GET['id']]);
write_config();
diff --git a/src/usr/local/www/interfaces_qinq.php b/src/usr/local/www/interfaces_qinq.php
index 63fa1b4..1997c19 100644
--- a/src/usr/local/www/interfaces_qinq.php
+++ b/src/usr/local/www/interfaces_qinq.php
@@ -67,7 +67,7 @@ if ($_GET['act'] == "del") {
}
mwexec("/usr/sbin/ngctl shutdown {$qinq['vlanif']}qinq:");
mwexec("/usr/sbin/ngctl shutdown {$qinq['vlanif']}:");
- mwexec("/sbin/ifconfig {$qinq['vlanif']} destroy");
+ pfSense_interface_destroy($qinq['vlanif']);
unset($a_qinqs[$id]);
write_config();
diff --git a/src/usr/local/www/interfaces_wireless.php b/src/usr/local/www/interfaces_wireless.php
index dafe49d..304eca2 100644
--- a/src/usr/local/www/interfaces_wireless.php
+++ b/src/usr/local/www/interfaces_wireless.php
@@ -57,7 +57,7 @@ if ($_GET['act'] == "del") {
if (clone_inuse($_GET['id'])) {
$input_errors[] = gettext("This wireless clone cannot be deleted because it is assigned as an interface.");
} else {
- mwexec("/sbin/ifconfig " . $a_clones[$_GET['id']]['cloneif'] . " destroy");
+ pfSense_interface_destroy($a_clones[$_GET['id']]['cloneif']);
unset($a_clones[$_GET['id']]);
write_config();
diff --git a/src/usr/local/www/interfaces_wireless_edit.php b/src/usr/local/www/interfaces_wireless_edit.php
index 419f9c6..d30b5c4 100644
--- a/src/usr/local/www/interfaces_wireless_edit.php
+++ b/src/usr/local/www/interfaces_wireless_edit.php
@@ -125,7 +125,7 @@ if ($_POST) {
} else {
if (isset($id) && $a_clones[$id]) {
if ($clone['if'] != $a_clones[$id]['if']) {
- mwexec("/sbin/ifconfig " . $a_clones[$id]['cloneif'] . " destroy");
+ pfSense_interface_destroy($a_clones[$id]['cloneif']);
}
$input_errors[] = sprintf(gettext("Created with id %s"), $id);
$a_clones[$id] = $clone;
OpenPOWER on IntegriCloud