diff options
| author | Phil Davis <phil.davis@inf.org> | 2016-06-08 12:04:53 +0930 |
|---|---|---|
| committer | Chris Buechler <cmb@pfsense.org> | 2016-06-09 17:07:22 -0400 |
| commit | 09cd43a8db6ced32b640731936c72cd5ea340cfc (patch) | |
| tree | d1a519714c23705f2c78076ab886b7e183d56007 | |
| parent | 1929acf18ff249f76ef00d2bfacd772397d01634 (diff) | |
| download | pfsense-09cd43a8db6ced32b640731936c72cd5ea340cfc.zip pfsense-09cd43a8db6ced32b640731936c72cd5ea340cfc.tar.gz | |
Fix #6468 Do not allow edit of day and times
in rows of time ranges for a schedule.
The code was always intended that the user uses the calendar pad and start hour/minute stop hour/minute drop-down fields to enter days and time range. If an existing day-time-range is wrong, then the workflow is to delete the row and then enter the correct day-time-range using the calendar pad and start hour/minute stop hour/minute drop-down fields.
I left the Description field as editable - there is not harm here in letting the user fixup text in any of the dsecriptions for each row.
| -rw-r--r-- | src/usr/local/www/firewall_schedule_edit.php | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/usr/local/www/firewall_schedule_edit.php b/src/usr/local/www/firewall_schedule_edit.php index 26470d8..2a81be7 100644 --- a/src/usr/local/www/firewall_schedule_edit.php +++ b/src/usr/local/www/firewall_schedule_edit.php @@ -624,21 +624,21 @@ if ($getSchedule) { null, 'text', $tempFriendlyTime - ))->setWidth(2)->setHelp($counter == $maxrows ? 'Day(s)':''); + ))->setWidth(2)->setReadonly()->setHelp($counter == $maxrows ? 'Day(s)':''); $group->add(new Form_Input( 'starttime' . $counter, null, 'text', $starttime - ))->setWidth(2)->setHelp($counter == $maxrows ? 'Start time':''); + ))->setWidth(2)->setReadonly()->setHelp($counter == $maxrows ? 'Start time':''); $group->add(new Form_Input( 'stoptime' . $counter, null, 'text', $stoptime - ))->setWidth(2)->setHelp($counter == $maxrows ? 'Stop time':''); + ))->setWidth(2)->setReadonly()->setHelp($counter == $maxrows ? 'Stop time':''); $group->add(new Form_Input( 'timedescr' . $counter, @@ -1127,15 +1127,15 @@ function insertElements(tempFriendlyTime, starttimehour, starttimemin, stoptimeh '<div class="form-group schedulegrp' + counter + '">' + '<label for="tempFriendlyTime@" class="col-sm-2 control-label"></label>' + '<div class="col-sm-2">' + - '<input class="form-control" name="tempFriendlyTime@" id="tempFriendlyTime@" type="text" value="' + tempFriendlyTime + '"/>' + + '<input class="form-control" name="tempFriendlyTime@" id="tempFriendlyTime@" type="text" readonly="readonly" value="' + tempFriendlyTime + '"/>' + '<span class="help-block">Day(s)</span>' + '</div>' + '<div class="col-sm-2">' + - '<input class="form-control" name="starttime@" id="starttime@" type="text" value="' + starttimehour + ':' + starttimemin + '"/>' + + '<input class="form-control" name="starttime@" id="starttime@" type="text" readonly="readonly" value="' + starttimehour + ':' + starttimemin + '"/>' + '<span class="help-block">Start time</span>' + '</div>' + '<div class="col-sm-2">' + - '<input class="form-control" name="stoptime@" id="stoptime@" type="text" value="' + stoptimehour + ':' + stoptimemin + '"/>' + + '<input class="form-control" name="stoptime@" id="stoptime@" type="text" readonly="readonly" value="' + stoptimehour + ':' + stoptimemin + '"/>' + '<span class="help-block">Stop time</span>' + '</div>' + '<div class="col-sm-2">' + |
