diff options
| author | Ermal <eri@pfsense.org> | 2010-10-04 13:09:29 +0000 |
|---|---|---|
| committer | Ermal <eri@pfsense.org> | 2010-10-04 13:09:29 +0000 |
| commit | a17027a6b30912b3afdb8d5888dce236cfa2c176 (patch) | |
| tree | 8d8324579ea8bfecf46b7edece04ee438e5fbc71 | |
| parent | 9cc0dd730ec8194de137732278a5b2ea63242cd3 (diff) | |
| download | pfsense-a17027a6b30912b3afdb8d5888dce236cfa2c176.zip pfsense-a17027a6b30912b3afdb8d5888dce236cfa2c176.tar.gz | |
Do not try to update dyndns for an interface that no ip can be determined, since it will not suceed. Reported-by: http://forum.pfsense.org/index.php/topic,28750.0.html
| -rw-r--r-- | etc/inc/dyndns.class | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/etc/inc/dyndns.class b/etc/inc/dyndns.class index 1b332d0..a5799d9 100644 --- a/etc/inc/dyndns.class +++ b/etc/inc/dyndns.class @@ -122,11 +122,12 @@ $this->_dnsMX = $dnsMX; $this->_if = get_real_interface($dnsIf); $this->_ifIP = get_interface_ip($dnsIf); - //$this->_dnsIP = get_interface_ip($dnsIf); // Ensure that we where able to lookup the IP - if(!$this->_ifIP) - log_error("There was an error trying to determine the IP for interface - {$dnsIf}({$this->_if})."); + if(!$this->_ifIP) { + log_error("There was an error trying to determine the IP for interface - {$dnsIf}({$this->_if}). Probably interface has no ip or is down. Dyndns update not possible for {$dnsService}."); + return; + } $this->_debugID = rand(1000000, 9999999); |
