summaryrefslogtreecommitdiffstats
path: root/drivers/thunderbolt
diff options
context:
space:
mode:
authorHimangi Saraogi <himangi774@gmail.com>2014-07-06 21:43:42 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-07-07 18:56:20 -0700
commitfc51768ba24077c8148067036e1555a8a978bb99 (patch)
tree4f200c86b37c782ad478e922c1e86e3e241d462e /drivers/thunderbolt
parent6b5fa77608352f05769ca4e10ec3a32d1446b4a6 (diff)
downloadop-kernel-dev-fc51768ba24077c8148067036e1555a8a978bb99.zip
op-kernel-dev-fc51768ba24077c8148067036e1555a8a978bb99.tar.gz
thunderbolt: Correct the size argument to devm_kzalloc
nhi->rx_rings does not have type as struct tb_ring *, as it is a double pointer so the elements of the array should have pointer type, not structure type. The Coccinelle semantic patch that makes this change is as follows: // <smpl> @disable sizeof_type_expr@ type T; T **x; @@ x = <+...sizeof( - T + *x )...+> // </smpl> Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Cc: Andreas Noever <andreas.noever@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/thunderbolt')
-rw-r--r--drivers/thunderbolt/nhi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
index 2054fbf..ce72f31 100644
--- a/drivers/thunderbolt/nhi.c
+++ b/drivers/thunderbolt/nhi.c
@@ -570,10 +570,10 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
INIT_WORK(&nhi->interrupt_work, nhi_interrupt_work);
nhi->tx_rings = devm_kzalloc(&pdev->dev,
- nhi->hop_count * sizeof(struct tb_ring),
+ nhi->hop_count * sizeof(*nhi->tx_rings),
GFP_KERNEL);
nhi->rx_rings = devm_kzalloc(&pdev->dev,
- nhi->hop_count * sizeof(struct tb_ring),
+ nhi->hop_count * sizeof(*nhi->rx_rings),
GFP_KERNEL);
if (!nhi->tx_rings || !nhi->rx_rings)
return -ENOMEM;
OpenPOWER on IntegriCloud