From fc51768ba24077c8148067036e1555a8a978bb99 Mon Sep 17 00:00:00 2001 From: Himangi Saraogi Date: Sun, 6 Jul 2014 21:43:42 +0530 Subject: thunderbolt: Correct the size argument to devm_kzalloc nhi->rx_rings does not have type as struct tb_ring *, as it is a double pointer so the elements of the array should have pointer type, not structure type. The Coccinelle semantic patch that makes this change is as follows: // @disable sizeof_type_expr@ type T; T **x; @@ x = <+...sizeof( - T + *x )...+> // Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall Cc: Andreas Noever Signed-off-by: Greg Kroah-Hartman --- drivers/thunderbolt/nhi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/thunderbolt') diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index 2054fbf..ce72f31 100644 --- a/drivers/thunderbolt/nhi.c +++ b/drivers/thunderbolt/nhi.c @@ -570,10 +570,10 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id) INIT_WORK(&nhi->interrupt_work, nhi_interrupt_work); nhi->tx_rings = devm_kzalloc(&pdev->dev, - nhi->hop_count * sizeof(struct tb_ring), + nhi->hop_count * sizeof(*nhi->tx_rings), GFP_KERNEL); nhi->rx_rings = devm_kzalloc(&pdev->dev, - nhi->hop_count * sizeof(struct tb_ring), + nhi->hop_count * sizeof(*nhi->rx_rings), GFP_KERNEL); if (!nhi->tx_rings || !nhi->rx_rings) return -ENOMEM; -- cgit v1.1