diff options
| author | Andy Shevchenko <andy.shevchenko@gmail.com> | 2010-10-11 16:58:33 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-10-12 09:03:29 -0700 |
| commit | ba07d0cbc919613ce48acc0a43d6e8ab35cd7748 (patch) | |
| tree | d9f5e52e0409928d462f69e7a1ad4293d85d8c53 /drivers/staging/brcm80211/util/bcmsrom.c | |
| parent | 88b3eaa499ddbe5a36c34840117563bd54ec4ec2 (diff) | |
| download | op-kernel-dev-ba07d0cbc919613ce48acc0a43d6e8ab35cd7748.zip op-kernel-dev-ba07d0cbc919613ce48acc0a43d6e8ab35cd7748.tar.gz | |
staging: brcm80211: remove useless bcm_ether_ntoa()
Since we have '%pM' modifier in the kernel's *printf() we don't need to
convert address to the string beforehand.
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Nohee Ko <noheek@broadcom.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-wireless@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/brcm80211/util/bcmsrom.c')
| -rw-r--r-- | drivers/staging/brcm80211/util/bcmsrom.c | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/drivers/staging/brcm80211/util/bcmsrom.c b/drivers/staging/brcm80211/util/bcmsrom.c index 1c02c92..f5212a0 100644 --- a/drivers/staging/brcm80211/util/bcmsrom.c +++ b/drivers/staging/brcm80211/util/bcmsrom.c @@ -504,10 +504,8 @@ int srom_parsecis(osl_t *osh, u8 *pcis[], uint ciscnt, char **vars, uint *count) && !(ETHER_ISMULTI(&cis[i + 2]))) { ASSERT(cis[i + 1] == ETHER_ADDR_LEN); - bcm_ether_ntoa( - (struct ether_addr *) - &cis[i + 2], - eabuf); + snprintf(eabuf, sizeof(eabuf), + "%pM", &cis[i + 2]); /* set boardnum if HNBU_BOARDNUM not seen yet */ if (boardnum == -1) @@ -976,10 +974,8 @@ int srom_parsecis(osl_t *osh, u8 *pcis[], uint ciscnt, char **vars, uint *count) case HNBU_MACADDR: if (!(ETHER_ISNULLADDR(&cis[i + 1])) && !(ETHER_ISMULTI(&cis[i + 1]))) { - bcm_ether_ntoa( - (struct ether_addr *) - &cis[i + 1], - eabuf); + snprintf(eabuf, sizeof(eabuf), + "%pM", &cis[i + 1]); /* set boardnum if HNBU_BOARDNUM not seen yet */ if (boardnum == -1) @@ -1728,7 +1724,6 @@ static void _initvars_srom_pci(u8 sromrev, u16 *srom, uint off, varbuf_t *b) continue; if (flags & SRFL_ETHADDR) { - char eabuf[ETHER_ADDR_STR_LEN]; struct ether_addr ea; ea.octet[0] = (srom[srv->off - off] >> 8) & 0xff; @@ -1737,9 +1732,8 @@ static void _initvars_srom_pci(u8 sromrev, u16 *srom, uint off, varbuf_t *b) ea.octet[3] = srom[srv->off + 1 - off] & 0xff; ea.octet[4] = (srom[srv->off + 2 - off] >> 8) & 0xff; ea.octet[5] = srom[srv->off + 2 - off] & 0xff; - bcm_ether_ntoa(&ea, eabuf); - varbuf_append(b, "%s=%s", name, eabuf); + varbuf_append(b, "%s=%pM", name, ea.octet); } else { ASSERT(mask_valid(srv->mask)); ASSERT(mask_width(srv->mask)); |
