From ba07d0cbc919613ce48acc0a43d6e8ab35cd7748 Mon Sep 17 00:00:00 2001 From: Andy Shevchenko Date: Mon, 11 Oct 2010 16:58:33 +0300 Subject: staging: brcm80211: remove useless bcm_ether_ntoa() Since we have '%pM' modifier in the kernel's *printf() we don't need to convert address to the string beforehand. Signed-off-by: Andy Shevchenko Cc: Nohee Ko Cc: Greg Kroah-Hartman Cc: linux-wireless@vger.kernel.org Cc: devel@driverdev.osuosl.org Signed-off-by: Greg Kroah-Hartman --- drivers/staging/brcm80211/util/bcmsrom.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) (limited to 'drivers/staging/brcm80211/util/bcmsrom.c') diff --git a/drivers/staging/brcm80211/util/bcmsrom.c b/drivers/staging/brcm80211/util/bcmsrom.c index 1c02c92..f5212a0 100644 --- a/drivers/staging/brcm80211/util/bcmsrom.c +++ b/drivers/staging/brcm80211/util/bcmsrom.c @@ -504,10 +504,8 @@ int srom_parsecis(osl_t *osh, u8 *pcis[], uint ciscnt, char **vars, uint *count) && !(ETHER_ISMULTI(&cis[i + 2]))) { ASSERT(cis[i + 1] == ETHER_ADDR_LEN); - bcm_ether_ntoa( - (struct ether_addr *) - &cis[i + 2], - eabuf); + snprintf(eabuf, sizeof(eabuf), + "%pM", &cis[i + 2]); /* set boardnum if HNBU_BOARDNUM not seen yet */ if (boardnum == -1) @@ -976,10 +974,8 @@ int srom_parsecis(osl_t *osh, u8 *pcis[], uint ciscnt, char **vars, uint *count) case HNBU_MACADDR: if (!(ETHER_ISNULLADDR(&cis[i + 1])) && !(ETHER_ISMULTI(&cis[i + 1]))) { - bcm_ether_ntoa( - (struct ether_addr *) - &cis[i + 1], - eabuf); + snprintf(eabuf, sizeof(eabuf), + "%pM", &cis[i + 1]); /* set boardnum if HNBU_BOARDNUM not seen yet */ if (boardnum == -1) @@ -1728,7 +1724,6 @@ static void _initvars_srom_pci(u8 sromrev, u16 *srom, uint off, varbuf_t *b) continue; if (flags & SRFL_ETHADDR) { - char eabuf[ETHER_ADDR_STR_LEN]; struct ether_addr ea; ea.octet[0] = (srom[srv->off - off] >> 8) & 0xff; @@ -1737,9 +1732,8 @@ static void _initvars_srom_pci(u8 sromrev, u16 *srom, uint off, varbuf_t *b) ea.octet[3] = srom[srv->off + 1 - off] & 0xff; ea.octet[4] = (srom[srv->off + 2 - off] >> 8) & 0xff; ea.octet[5] = srom[srv->off + 2 - off] & 0xff; - bcm_ether_ntoa(&ea, eabuf); - varbuf_append(b, "%s=%s", name, eabuf); + varbuf_append(b, "%s=%pM", name, ea.octet); } else { ASSERT(mask_valid(srv->mask)); ASSERT(mask_width(srv->mask)); -- cgit v1.1