summaryrefslogtreecommitdiffstats
path: root/hw
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2012-10-24 18:14:00 +0200
committerGerd Hoffmann <kraxel@redhat.com>2012-10-25 09:08:09 +0200
commitcf08a8a1f600b2ac25f72cf5736247f3e95cc43d (patch)
treefa78b5a407caec549bda5d9c09bf29e7d4c5ad34 /hw
parent549a3c3d9665bdc0246fb6594b6e36ce3afadd21 (diff)
downloadhqemu-cf08a8a1f600b2ac25f72cf5736247f3e95cc43d.zip
hqemu-cf08a8a1f600b2ac25f72cf5736247f3e95cc43d.tar.gz
ehci: Set int flag on a short input packet
According to 4.15.1.2 an interrupt must be raised when a short packet is received. If we don't do this it may take a significant time for the guest to notice a short trasnfer has completed, since only the last td will have its IOC flag set, and a short transfer may complete in an earlier packet. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw')
-rw-r--r--hw/usb/hcd-ehci.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 82f4dbd..8b4e3c8 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -1508,6 +1508,10 @@ static void ehci_execute_complete(EHCIQueue *q)
if (tbytes && p->pid == USB_TOKEN_IN) {
tbytes -= p->usb_status;
+ if (tbytes) {
+ /* 4.15.1.2 must raise int on a short input packet */
+ ehci_raise_irq(q->ehci, USBSTS_INT);
+ }
} else {
tbytes = 0;
}
OpenPOWER on IntegriCloud