diff options
author | Markus Armbruster <armbru@redhat.com> | 2014-05-02 13:26:34 +0200 |
---|---|---|
committer | Luiz Capitulino <lcapitulino@redhat.com> | 2014-05-09 09:11:31 -0400 |
commit | 415168e0c7bda5371a876914d4fdb68c4556f28d (patch) | |
tree | 31a7ac1f696816f8768ce1434120888c82702ece /hmp.c | |
parent | a903f40c314c57734ffd651786c953541cfc43a8 (diff) | |
download | hqemu-415168e0c7bda5371a876914d4fdb68c4556f28d.zip hqemu-415168e0c7bda5371a876914d4fdb68c4556f28d.tar.gz |
hmp: Guard against misuse of hmp_handle_error()
Null errp argument makes no sense. Assert it's not null, to make this
explicit, and guard against misuse. All current callers pass non-null
errp.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Diffstat (limited to 'hmp.c')
-rw-r--r-- | hmp.c | 3 |
1 files changed, 2 insertions, 1 deletions
@@ -28,7 +28,8 @@ static void hmp_handle_error(Monitor *mon, Error **errp) { - if (error_is_set(errp)) { + assert(errp); + if (*errp) { monitor_printf(mon, "%s\n", error_get_pretty(*errp)); error_free(*errp); } |