diff options
| author | Stefan Weil <sw@weilnetz.de> | 2014-08-04 14:41:55 +0100 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2014-08-04 14:41:55 +0100 |
| commit | cdcf14057d780cdbb1f89f8c5fc11a1a9184b5b1 (patch) | |
| tree | f01818e17029247279d4e162ce17aa311c261a5f | |
| parent | 63b60551a7a4846de2f1f41dd37296fa1571d27e (diff) | |
| download | hqemu-cdcf14057d780cdbb1f89f8c5fc11a1a9184b5b1.zip hqemu-cdcf14057d780cdbb1f89f8c5fc11a1a9184b5b1.tar.gz | |
target-arm: Fix bit test in sp_el0_access
Static code analyzers complain about a dubious & operation used for a
boolean value. The code does not test the PSTATE_SP bit as it should.
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Message-id: 1406359601-25583-1-git-send-email-sw@weilnetz.de
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
| -rw-r--r-- | target-arm/helper.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target-arm/helper.c b/target-arm/helper.c index a7f82f3..d709285 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -1853,7 +1853,7 @@ static uint64_t aa64_dczid_read(CPUARMState *env, const ARMCPRegInfo *ri) static CPAccessResult sp_el0_access(CPUARMState *env, const ARMCPRegInfo *ri) { - if (!env->pstate & PSTATE_SP) { + if (!(env->pstate & PSTATE_SP)) { /* Access to SP_EL0 is undefined if it's being used as * the stack pointer. */ |
