diff options
| author | Greg Kurz <gkurz@linux.vnet.ibm.com> | 2015-07-02 16:23:11 +1000 |
|---|---|---|
| committer | Alexander Graf <agraf@suse.de> | 2015-07-07 17:44:51 +0200 |
| commit | 4d9ab7d4ed46c63d047862d11946996005742a09 (patch) | |
| tree | 2d2ab34f8ba114e4d0fa5b5f12f2b0122ff6d38a | |
| parent | 9b7d9284c3b114112a7759ce0a885df0767fe8d9 (diff) | |
| download | hqemu-4d9ab7d4ed46c63d047862d11946996005742a09.zip hqemu-4d9ab7d4ed46c63d047862d11946996005742a09.tar.gz | |
spapr_iommu: drop erroneous check in h_put_tce_indirect()
The tce_list variable is not a TCE but the address to a TCE: we shouldn't
clear permission bits as we do now. And this is dead code anyway since we
check tce_list is 4K aligned a few lines above.
This patch doesn't fix any bug, it is only code cleanup.
Suggested-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
| -rw-r--r-- | hw/ppc/spapr_iommu.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index d58d9ba..3121998 100644 --- a/hw/ppc/spapr_iommu.c +++ b/hw/ppc/spapr_iommu.c @@ -267,9 +267,7 @@ static target_ulong h_put_tce_indirect(PowerPCCPU *cpu, ioba &= page_mask; for (i = 0; i < npages; ++i, ioba += page_size) { - target_ulong off = (tce_list & ~SPAPR_TCE_RW) + - i * sizeof(target_ulong); - tce = ldq_be_phys(cs->as, off); + tce = ldq_be_phys(cs->as, tce_list + i * sizeof(target_ulong)); ret = put_tce_emu(tcet, ioba, tce); if (ret) { |
