summaryrefslogtreecommitdiffstats
path: root/programmer.h
diff options
context:
space:
mode:
authorStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>2011-05-26 01:35:19 +0000
committerStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>2011-05-26 01:35:19 +0000
commit55547acb4db4fb497060d2e14c412e9fd8cd1f26 (patch)
tree8b540af2f9c993133ddb6cd3a513289dfbe7f549 /programmer.h
parent59f1dc75f79b28c0bce4751920e4cba7f556899c (diff)
downloadflashrom-55547acb4db4fb497060d2e14c412e9fd8cd1f26.zip
flashrom-55547acb4db4fb497060d2e14c412e9fd8cd1f26.tar.gz
Eliminate magic numbers indicating maximum column sizes in print_supported_chipsets and print_supported_boards_helper
Without this the magic numbers need to be kept in sync with the maximum length of the strings printed in the corresponding column. if not, an overflow and a nasty ' '-storm occur on executing flashrom -L. Corresponding to flashrom svn r1318. Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Diffstat (limited to 'programmer.h')
-rw-r--r--programmer.h8
1 files changed, 4 insertions, 4 deletions
diff --git a/programmer.h b/programmer.h
index b68aa88..e1147f1 100644
--- a/programmer.h
+++ b/programmer.h
@@ -145,7 +145,7 @@ struct bitbang_spi_master {
struct penable {
uint16_t vendor_id;
uint16_t device_id;
- int status;
+ int status; /* OK=0 and NT=1 are defines only. Beware! */
const char *vendor_name;
const char *device_name;
int (*doit) (struct pci_dev *dev, const char *name);
@@ -174,10 +174,10 @@ struct board_pciid_enable {
uint16_t second_card_vendor;
uint16_t second_card_device;
- /* Pattern to match DMI entries */
+ /* Pattern to match DMI entries. May be NULL. */
const char *dmi_pattern;
- /* The vendor / part name from the coreboot table. */
+ /* The vendor / part name from the coreboot table. May be NULL. */
const char *lb_vendor;
const char *lb_part;
@@ -188,7 +188,7 @@ struct board_pciid_enable {
int max_rom_decode_parallel;
int status;
- int (*enable) (void);
+ int (*enable) (void); /* May be NULL. */
};
extern const struct board_pciid_enable board_pciid_enables[];
OpenPOWER on IntegriCloud